From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] usb: dwc2: Throttle the setup packet resending
Date: Fri, 06 May 2016 20:04:38 +0200 [thread overview]
Message-ID: <572CDCB6.7040404@denx.de> (raw)
In-Reply-To: <572A2C86.7070604@wwwdotorg.org>
On 05/04/2016 07:08 PM, Stephen Warren wrote:
> On 05/03/2016 02:51 PM, Marek Vasut wrote:
>> Abort the request in case any of the tokens in the packet failed to
>> complete transfer 10 times. This is a precaution needed so that we
>> don't end in endless loop when scanning the bus with some braindead
>> devices.
>
> Does this affect USB keyboards when SYS_USB_EVENT_POLL_VIA_CONTROL_EP is
> enabled? IIRC control transactions to HID devices can be held off for
> some duration based on polling intervals, and this patch might abort
> them early?
>
> Or do we typically expect to use interrupt transfers for keyboards, so
> this isn't too relevant (although there are some platforms that enable
> SYS_USB_EVENT_POLL_VIA_CONTROL_EP). Maybe not DWC2 platforms though; I
> didn't check.
Hm, I found one keyboard with which I have trouble with 2/7 and 3/7 , so
I will drop them from my USB PR. This means half of my USB sticks will
no longer work again, but at least it won't introduce any regressions.
We need to revisit this for 2016.07. Do you have any ideas how to deal
with this ? I am tempted to just add udelay(125); after each control
transfer.
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-05-06 18:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 20:51 [U-Boot] [PATCH 1/7] usb: Don't init pointer to zero, but NULL Marek Vasut
2016-05-03 20:51 ` [U-Boot] [PATCH 2/7] usb: dwc2: Resend setup packet in all fail cases Marek Vasut
2016-05-04 9:36 ` Chin Liang See
2016-05-03 20:51 ` [U-Boot] [PATCH 3/7] usb: dwc2: Throttle the setup packet resending Marek Vasut
2016-05-04 9:37 ` Chin Liang See
2016-05-04 17:08 ` Stephen Warren
2016-05-04 21:21 ` Marek Vasut
2016-05-06 18:04 ` Marek Vasut [this message]
2016-05-03 20:51 ` [U-Boot] [PATCH 4/7] usb: Wait after sending Set Configuration request Marek Vasut
2016-05-04 7:41 ` Stefan Roese
2016-05-04 9:45 ` Chin Liang See
2016-05-04 10:00 ` Stefan Roese
2016-05-04 10:24 ` Chin Liang See
2016-05-05 4:14 ` Sriram Dash
2016-05-04 10:21 ` Marek Vasut
2016-05-03 20:51 ` [U-Boot] [PATCH 5/7] usb: Assure Get Descriptor request is in separate microframe Marek Vasut
2016-05-04 8:03 ` Stefan Roese
2016-05-04 10:25 ` Marek Vasut
2016-05-04 17:10 ` Stephen Warren
2016-05-03 20:51 ` [U-Boot] [PATCH 6/7] usb: hub: Don't continue on get_port_status failure Marek Vasut
2016-05-04 8:05 ` Stefan Roese
2016-05-04 9:38 ` Chin Liang See
2016-05-03 20:51 ` [U-Boot] [PATCH 7/7] usb: hub: Increase the query delay Marek Vasut
2016-05-04 8:07 ` Stefan Roese
2016-05-04 11:39 ` Marek Vasut
2016-05-04 16:27 ` Stefan Roese
2016-05-04 17:11 ` Stephen Warren
2016-05-04 21:32 ` [U-Boot] [PATCH] " Marek Vasut
2016-05-04 21:34 ` Stephen Warren
2016-05-04 21:38 ` Marek Vasut
2016-05-04 7:36 ` [U-Boot] [PATCH 1/7] usb: Don't init pointer to zero, but NULL Stefan Roese
2016-05-04 9:35 ` Chin Liang See
2016-05-06 16:36 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572CDCB6.7040404@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox