From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 09 May 2016 00:09:46 +0200 Subject: [U-Boot] [PATCH] net: Add ag7xxx driver for Atheros MIPS In-Reply-To: References: <1462476853-7317-1-git-send-email-marex@denx.de> Message-ID: <572FB92A.8060502@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/08/2016 11:25 PM, Amit Tomer wrote: > Hello! Hi! >> + >> +#define CONFIG_TX_DESCR_NUM 8 >> +#define CONFIG_RX_DESCR_NUM 8 >> +#define CONFIG_ETH_BUFSIZE 2048 > > Isn't it too BIG size for normal ethernet frame, unless we need Jumbo Frame ? It is the next larger power of two from the 1536B ethernet frame, which has the benefit: - The buffers are aligned to half the page size (on this machine) - There is enough space of oversized packets (due to tags etc) Jumbo frames are 9k, they are not supported by u-boot and won't fit anyway. Given the size of DRAM on MIPS machines with this SoC, microoptimizing here seems pointless to me. > Thanks, > Amit. > -- Best regards, Marek Vasut