[U-Boot] [PATCH v2 1/3] dm: gpio: Add driver for MPC85XX GPIO controller

Mario Six
2016-05-10T13:07:38Z

On Tue, May 10, 2016 at 2:30 PM, Timur Tabi <timur@tabi.org> wrote:

> Mario Six wrote:
>
>> + addr = fdtdec_get_addr_size_auto_noparent(gd->fdt_blob,
>> dev->of_offset,
>> + "reg", 0, &size);
>>
>
> Why can't you use platform_get_resource()?
>
>
platform_get_resource is from the kernel, not U-Boot ;-) (Unless I've missed
something and it has been implemented without me noticing).

I suppose I could use dev_get_addr and just use sizeof(...) for the iomem
allocation, but then I would ignore the size from the device tree, which
doesn't sit well with me. But that'd be fine, too (it does look a bit
neater, I
admit). If Simon wants me to do it that way, I will.

Best regards,
Mario