From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CA1CC761A6 for ; Thu, 30 Mar 2023 13:36:03 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 16D5585EA2; Thu, 30 Mar 2023 15:35:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="CEcP/st7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 92A3885EC1; Thu, 30 Mar 2023 15:35:55 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2062f.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 633AF85B3F for ; Thu, 30 Mar 2023 15:35:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1/lvwSbuSYmn1pl28enIoX8z4UN8r2erLEyVc7voDX8hX3O/NeWmq/PjMqQQcII4dIfQ+0EU/XwU8svsZsCFgBG2adY00pKIV5oSgBO6M42o737X2sjs5/t2b6tokyyDJVqPKt219UM90jmdqBRVUs97yB49afk0BJVhs4z5GxLlpy9Gmhm6xvN9ZxnCJGD6eJ/dSt7WjwF7wKI9etqLzln73nKVDSNSD3+pm3/3hGIP4YT+/8+7Z7zAw/1YGL/Zof25eSGvwKaqtoX00yq2GyJlPoPkD24G+6bZI4O+lNxaClrjIg+ZnWtC37jiIN7hyFRC3tmpUZPhSzYDkW8Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oDb1eVQl30wq0dYGCHp1lcvTuvKlYEm6A8yasL18j9Q=; b=R5eSW1QeWMniDImctOZoDU2Yq0rgNJiZ09iLL+grczsYjRvQAYylgL0JEN5hKILDhEvVu5otexSRSfg+5cuF/XuBF6ylzRm4JAp45bil8Jz3EWBx//SV9CM6KuuhsS5bjk3Y0uVDJCOHVzNnNO8PvKohRs1LqDV1GnMIveOqnxjkAytAPeqfkaG89NyA+mR4X9Q1LALLxtR1ELGJ82kLRi7MKjP5zYa4E7O01In0m0pTJk2sg8BkA+3AOwPcqj+nVRucvrT8Ay8TBrbkfr+9+clALcqlEklKTVgi4vVEovRf4dZoGUnRQ7U65xbFKrJvei6bY/fS/UvCvVWIIf6VPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oDb1eVQl30wq0dYGCHp1lcvTuvKlYEm6A8yasL18j9Q=; b=CEcP/st7uYVgTOTyld4nArjbTdsd4h+0wWIuIeYQXGK+CMVjHYXCzii/OgQ1YWo6W6unjorUDRDf66JxvGFO8QRbrQFclZyTMEWEG4Rvj6aXPY9LuML8SDwBL8Ivy/LgUTI+0hryRFvcBzQNKWw86DtcjkAT5MsAOEhROtXN4SE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by PH7PR12MB8055.namprd12.prod.outlook.com (2603:10b6:510:268::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.33; Thu, 30 Mar 2023 13:35:48 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::4d07:7f52:c833:9603]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::4d07:7f52:c833:9603%6]) with mapi id 15.20.6222.035; Thu, 30 Mar 2023 13:35:48 +0000 Message-ID: <5731dcce-a9bb-320f-9680-0cb33db3eb7b@amd.com> Date: Thu, 30 Mar 2023 15:35:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: jassisinghbrar@gmail.com, u-boot@lists.denx.de Cc: ilias.apalodimas@linaro.org, etienne.carriere@linaro.org, trini@konsulko.com, sjg@chromium.org, sughosh.ganu@linaro.org, xypron.glpk@gmx.de, takahiro.akashi@linaro.org, Jassi Brar References: <20230327211458.498879-1-jaswinder.singh@linaro.org> From: Michal Simek Subject: Re: [PATCH v4 0/6] FWU: Add support for mtd backed feature on DeveloperBox In-Reply-To: <20230327211458.498879-1-jaswinder.singh@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1P190CA0032.EURP190.PROD.OUTLOOK.COM (2603:10a6:802:2b::45) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|PH7PR12MB8055:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f7c502e-e68c-4c95-7d9c-08db3123abd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rZLWW1vazKhKHndZAFjigIGFje0qDpPrrhmXcnRVgHMhY87TBuYaXPxfjLaID8TQCVdNty64EUOjgxWxsBEIzNP5Q8PEw0lJ9BbYmjC6WDVNJoyh31KnQIRTBDVQRKLvz74lplFl43SeOWjL5TLHMJtcLBX5IX41kUihnUSdk8fFdCqTilEgqsIUE7phvdBpcdfHwgH10SLzdGpBo0we9LxVpwnjtOfgxtcgwKF938xAIzEurpcUG4YEu/1a2RMyy2SmwmSlPIOnQlBqfXg5cA1WmSnmHiW2KasQsAJCiZuDJMO76TAm+MEzNFx0izIdN7JRaZDwENUrQo3BBqZEpCkFmcpY14DNRZIQztJVVVG2urQ1eoML6O1sISTgBut7pysUI8wmYkz1YNwoIf7HVKpHCEKeMoTLsUGE7/+El9gWoja6F74Nya96eJLwPGDIGiR9soffe6hqKE51SszfQf9q8LL/okKRiErNcqaugfb7uh5l8/QuSDCim9Xy5eSE6ocdmtCmMu1+GVGjqxZYXFGSaiwwexU26n7ehOFD60vNAPArzB+TRX8PpgoxzCCbSHkx8juUv6BqQ6d+tyZ3rTOKE0kdL6b4rAkqJ0d6r6Iq3dluzJNSZ5JAQOhQnuTkGwi5WZTW7qry+UC2pDJXTQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(451199021)(186003)(6512007)(6666004)(53546011)(6506007)(26005)(83380400001)(2616005)(31686004)(316002)(966005)(6486002)(8936002)(478600001)(38100700002)(44832011)(7416002)(5660300002)(86362001)(31696002)(66556008)(4326008)(66946007)(41300700001)(66476007)(8676002)(2906002)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGFGUlZST2kwYlRrWC9yWTJJbWpTZFljWHc0RjArbHZzam9YTVlxbEZQY2NW?= =?utf-8?B?dkovY0ZyR3dPOWdsUjRqME1CeFNucS95YWVHZWJCeEh6eVgra05vZE1NdUJm?= =?utf-8?B?VjhidjVNNnZWaXhQditKbWIxNTJvYmVYT3NPVlNaUHp4MGFLQnhnWHA5TWJt?= =?utf-8?B?ZXcwYkhNWUlabmNsOVJZVDI4MVpFS0t0S0VmWEh4TVpFM1hDNnNSQ3Arb2FZ?= =?utf-8?B?UnFZOEU4ZTFvZUlBUE5Pejg4ek9jODZrMytxK2FHaU56ZU5TVVVVZTgzNjVy?= =?utf-8?B?akl3dHdTY2FpOUxkdVNqYjZVY3JtQ05maGgvcUhCMmNZbjJaQ1Yyb2FUMGJZ?= =?utf-8?B?eWtmTGZVZHFSNjlHMHUzOFBNdmVwRCt5QjRIdTkyTFVWN1NkZlk4ZnBwMFZn?= =?utf-8?B?TEM5QXdGaEZTL0FVVEJZTjZxcVBuQkJHbDBOQ0ZCd2k5bTVWTHBpZVZTbi83?= =?utf-8?B?TXZJajMwMHVoV3Y2T0gzdGowYW9EV0RWb0pvMVovdjFPRTdwSWc1ZkZEUjNU?= =?utf-8?B?RDJHang0UVN5R3hDbjVGcjBzUkZnaU1rL25JRVVBYlgxVzZDbk1EcCtMeU9L?= =?utf-8?B?c3lpNy9VbXRua3lNYkE0djFYeGl5ZExyUDVHcGk4eXh4OFVFcC9Pd3pHSGNp?= =?utf-8?B?V1ZiZFRiS1VnbEZUcmlHbEJIWjAyVmZ0V01LUXloR2tDZEJJWEEyRkFVS3hO?= =?utf-8?B?OGg5UXhRK3ZkMmlxaDlGMjlRN3FyY1V1clBEeVhpS3hJTnplL25VcTNoQkQr?= =?utf-8?B?L25NNU5La3lzdHZNNU5wanM5WFlVM2dYWTN6cXlDTmpON0hqL1B6YkNwMXlx?= =?utf-8?B?ZEptL3Q2Vm5PNkxrMGd3VGFFT29ESDNna0l2eTh4QkZvMjd1MSsyTUcwNzRZ?= =?utf-8?B?VGdoMGkxSWYrZ2lDK0lsNGlmT25RUGJFL3IzZmJNWUVGMnpmK3d5LzR3UjBH?= =?utf-8?B?RnhnNTRkWEZXVU5rSDJQQ1dQRmwwZC8yb2gvRDc1ZVJ4WktPTFlFeGQ2VU5y?= =?utf-8?B?MUVTT2pabFFMTjdiSExONkYzMlFodXNRRXY2b2Z5N2Q4Y0ZPb3Bja2JZQmNS?= =?utf-8?B?MWN0UjdEWTIxUE9FK3RhcmdVMCt2MlhZdjBPQndRaW50QVVMNExxN1EycXZ3?= =?utf-8?B?a2s4MDJTM2Qyc2xTcVUvdVBxNS9XTkVOK0Zsa1RGUWZzNjgySjZjVXJRVDBP?= =?utf-8?B?OXVWS3JlWDZtTTEwNHZkMzFRc3ZRTGNrMThLaWlKOUkzcTBpRklPTHZqL29B?= =?utf-8?B?TmdQaHlOdEtNTUhqUmVudmtmc3R4UkIyWnM0MUZMRVp4QXlib3Nhd2JRRXNI?= =?utf-8?B?bHhFNWZWdTVUcWdZeUZvcjQvZHd0SFFnR2RVNlczQTVzUGlvUGpMVmV3SEtU?= =?utf-8?B?NXpBc3loY1JOMktibU0wMVh3aXpoSXZPUm1HMzNmQXJ4RG1na01ZMll5dFhx?= =?utf-8?B?Y0U5WnR5WTBMQXJBNHRpZHhHUkVwN2FHeUQ3Vk5qbE03OU1lS1J1TU14T2Y5?= =?utf-8?B?dzJtb2NxY0xJY1owTVJwNDZoYnFidGNjaHBzeDA5a25PYjZaOE9DT1doNE5T?= =?utf-8?B?REI3cUhibWhOa0g4aDVoTTJ1cnVMalNhUDFmTmRBMDhZN0xkSzU4NDdhUU5Q?= =?utf-8?B?aE5tL2Fjd3lMRU1ZRlcvbkltSjJJRlhIT3NGQWtYMjhlNjh5a3UrS1pJWU1n?= =?utf-8?B?dW1JQVdydmhnK0QrZWxhd2hIMFRRV3I4dnRWMnhIbmZGSzNEeXBnT3hycUdD?= =?utf-8?B?bmtkcG51RDFrc3BkRnVGV04rK3M0d1I4T0RKSFlYT2kwR0RBamVEQjdaWUZ1?= =?utf-8?B?WWdjaSt4V0hjMytkRVZKM2dFWlJra2pVekU0dHkrSFhDc1BBZEhvL3dEbU9D?= =?utf-8?B?VTNiYS9XYTJlZnliQUZrUFhZMWM0UFJob3hYdmNZbUFWaVV4V1QvellEcmdI?= =?utf-8?B?enRqQ1ZMWGF1V3MxZE9VSzB6NjlLSGJ2NXhvWXZwMFF4TTNJQVduM3NOVjVv?= =?utf-8?B?Ry9CQjBQdVN2c0d4RDhBMi9GblN4OHVnT1Z5YzliTURnbTNnSG5ONHJLK2Y0?= =?utf-8?B?Y0JNeVYrM0V0Zys4bUhwY0dFZHgwLzVJMmpmbUZHQjVnTTZMQTFlRkJhWnVh?= =?utf-8?Q?riWjg3+VBLfVT4D0Cs5rBt/Rf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f7c502e-e68c-4c95-7d9c-08db3123abd7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 13:35:48.3257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h8GYuKP9uPG/oinay/Do0MDcJ2Z1qce1nhfsgAwpvOJGvevIrY3klZoP0BpQTHaA X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8055 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 3/27/23 23:14, jassisinghbrar@gmail.com wrote: > From: Jassi Brar > > Introduce support for mtd backed storage for FWU feature and enable it on > Synquacer platform based DeveloperBox. > > This revision is rebased onto patchset that trims the FWU api > https://lore.kernel.org/u-boot/20230306231747.1888513-1-jassisinghbrar@gmail.com/ > > Changes since v3: > * Fix and Update documentation to also build optee for FWU FIP image. > * Fixed checkpatch warnings > * Made local functions static. > * Split config changes to a separate patch > * Fix authorship of three patches. > > > Jassi Brar (3): > dt: fwu: developerbox: enable fwu banks and mdata regions > configs: move to new flash layout and boot flow > fwu: DeveloperBox: add support for FWU > > Masami Hiramatsu (3): > FWU: Add FWU metadata access driver for MTD storage regions > FWU: mtd: Add helper functions for accessing FWU metadata > tools: Add mkfwumdata tool for FWU metadata image > > .../synquacer-sc2a11-developerbox-u-boot.dtsi | 49 ++- > board/socionext/developerbox/Makefile | 1 + > board/socionext/developerbox/developerbox.c | 8 + > board/socionext/developerbox/fwu_plat.c | 57 +++ > configs/synquacer_developerbox_defconfig | 12 +- > doc/board/socionext/developerbox.rst | 155 +++++++- > drivers/fwu-mdata/Kconfig | 15 + > drivers/fwu-mdata/Makefile | 1 + > drivers/fwu-mdata/raw_mtd.c | 272 ++++++++++++++ > include/configs/synquacer.h | 10 + > include/fwu.h | 34 ++ > lib/fwu_updates/Makefile | 1 + > lib/fwu_updates/fwu_mtd.c | 164 +++++++++ > tools/Kconfig | 9 + > tools/Makefile | 4 + > tools/mkfwumdata.c | 334 ++++++++++++++++++ > 16 files changed, 1115 insertions(+), 11 deletions(-) > create mode 100644 board/socionext/developerbox/fwu_plat.c > create mode 100644 drivers/fwu-mdata/raw_mtd.c > create mode 100644 lib/fwu_updates/fwu_mtd.c > create mode 100644 tools/mkfwumdata.c > I have played with this more and I found other things. Ilias: mkeficapsule is accepting only guid and mkfwumdata is accepting only uuid or guids. And DT is having uuids only. I think it will be good to sync it up because you need to have both version for images generation which is a little bit painful. It should be possible to list only guids or uuids. And it is not clear to me how u-boot is talking to boot firmware about next boot index. fwu_plat_get_bootidx() returns index which booted but I can't see any hoook to tell from u-boot to boot firmware what should be image/index to boot after capsule update. I expect it should work like this. Boot to u-boot - let's say index 0. Run capsule update which will update index 1. Inform boot firmware to boot index 1 (this step I am missing) Call reset Boot to u-boot index 1. Apply accept capsule to confirm that image at index 1 is correct in case of error (watchdog for example) boot to u-boot index 0 apply revert capsule and disable index 1 image. Thanks, Michal