From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Date: Fri, 13 May 2016 15:27:52 +0300 Subject: [U-Boot] [PATCH 1/4] usb: dwc3: fix kconfig In-Reply-To: <5735C742.5010603@denx.de> References: <1463141873-10604-1-git-send-email-rogerq@ti.com> <1463141873-10604-2-git-send-email-rogerq@ti.com> <5735C742.5010603@denx.de> Message-ID: <5735C848.1090303@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13/05/16 15:23, Marek Vasut wrote: > On 05/13/2016 02:17 PM, Roger Quadros wrote: >> DWC3 can be used in host only or gadget only mode. >> >> Signed-off-by: Roger Quadros >> --- >> drivers/usb/dwc3/Kconfig | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig >> index e93398f..caf695b 100644 >> --- a/drivers/usb/dwc3/Kconfig >> +++ b/drivers/usb/dwc3/Kconfig >> @@ -1,15 +1,16 @@ >> config USB_DWC3 >> bool "DesignWare USB3 DRD Core Support" >> - depends on (USB && USB_GADGET) >> - select USB_GADGET_DUALSPEED >> + depends on (USB || USB_GADGET) >> + select USB_GADGET_DUALSPEED if USB_GADGET >> help >> - Say Y here if your system has a Dual Role SuperSpeed >> - USB controller based on the DesignWare USB3 IP Core. >> + Say Y here if your system has DesignWare USB3 IP Core. >> >> if USB_DWC3 >> >> choice >> bool "DWC3 Mode Selection" >> + default USB_DWC3_HOST if (USB && !USB_GADGET) >> + default USB_DWC3_GADGET if (!USB && USB_GADGET) > > What happens if I select both USB and USB_GADGET ? Ideally we want to have dual role operation but that code seems to have been stripped off from the dwc3/core.c. So till dual-role is added back it will work in HOST mode by default but user can still choose GADGET mode. > >> config USB_DWC3_HOST >> bool "Host only mode" >> > > cheers, -roger