From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Date: Mon, 16 May 2016 12:03:36 +0300 Subject: [U-Boot] [PATCH 4/4] usb: gadget: udc: Build on USB_GADGET In-Reply-To: <5735CCCB.3080207@denx.de> References: <1463141873-10604-1-git-send-email-rogerq@ti.com> <1463141873-10604-5-git-send-email-rogerq@ti.com> <5735C793.7000701@denx.de> <5735C8A8.3030102@ti.com> <5735CCCB.3080207@denx.de> Message-ID: <57398CE8.3010705@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13/05/16 15:47, Marek Vasut wrote: > On 05/13/2016 02:29 PM, Roger Quadros wrote: >> On 13/05/16 15:24, Marek Vasut wrote: >>> On 05/13/2016 02:17 PM, Roger Quadros wrote: >>>> udc-core is a generic framework and not specific to dwc3. >>>> So build it based on USB_GADGET. >>>> >>>> Signed-off-by: Roger Quadros >>>> --- >>>> drivers/usb/gadget/udc/Makefile | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/usb/gadget/udc/Makefile b/drivers/usb/gadget/udc/Makefile >>>> index 1699ccd..68766c5 100644 >>>> --- a/drivers/usb/gadget/udc/Makefile >>>> +++ b/drivers/usb/gadget/udc/Makefile >>>> @@ -4,4 +4,4 @@ >>>> # SPDX-License-Identifier: GPL-2.0+ >>>> # >>>> >>>> -obj-$(CONFIG_USB_DWC3_GADGET) += udc-core.o >>>> +obj-$(CONFIG_USB_GADGET) += udc-core.o >>>> >>> Did you buildman this against all boards ? >>> >> Nope, I've never used it before but I'll give it a shot. >> >> cheers, >> -roger >> > I use this script to do my buildmanning: > > # U-Boot: Quick build test > bubm() > {( > branch=`git branch | grep '^*' | sed "s/^..//"` > dir=/tmp/bm-$1 > arch="arm aarch64 mips powerpc nios2" > shift 1 > ./tools/buildman/buildman -o ${dir} -b ${branch} --step=0 ${arch} $@ > )} > Thanks Marek. This patch sure breaks all non DWC3 USB platforms. So let's drop this. I wasn't aware that every other gadget driver is implementing its own usb core API. cheers, -roger