From: Bernhard Nortmann <bernhard.nortmann@web.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] sunxi: Increase SPL header size to 64 bytes to avoid code corruption
Date: Mon, 16 May 2016 11:56:58 +0200 [thread overview]
Message-ID: <5739996A.7090806@web.de> (raw)
In-Reply-To: <1463188406-4707-1-git-send-email-siarhei.siamashka@gmail.com>
Given that there now are quite a few additional "reserved" entries, and
while we're still at SPL_HEADER_VERSION 1, I'd like to renew my request
of dedicating one of these fields to the script length - which would
enable us to set the U-Boot ${filesize} accordingly.
i.e.
--- arch-arm-include-asm-arch-sunxi-spl.h
+++ arch-arm-include-asm-arch-sunxi-spl.new.h
@@ -49,7 +49,8 @@
uint8_t spl_signature[4];
};
uint32_t fel_script_address;
- uint32_t reserved1[3];
+ uint32_t fel_script_length;
+ uint32_t reserved1[2];
uint32_t boot_media; /* written here by the boot ROM */
uint32_t reserved2[5]; /* padding, align to 64 bytes */
};
I do not intend to further push my specific use cases, however I still
consider the (then somewhat theoretical) ability to do "import -t
${fel_script_addr} ${filesize}" useful. For reference, the previous
discussion related to this was somewhere around
http://lists.denx.de/pipermail/u-boot/2015-September/227454.html
Regards, B. Nortmann
next prev parent reply other threads:[~2016-05-16 9:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 1:13 [U-Boot] [PATCH v2] sunxi: Increase SPL header size to 64 bytes to avoid code corruption Siarhei Siamashka
2016-05-15 10:04 ` Hans de Goede
2016-05-16 9:56 ` Bernhard Nortmann [this message]
2016-05-16 17:52 ` Hans de Goede
2016-06-02 14:57 ` Siarhei Siamashka
2016-06-03 7:30 ` Bernhard Nortmann
2016-06-03 10:53 ` Hans de Goede
2016-06-04 17:12 ` [U-Boot] [PATCH] sunxi: Add the ability to pass (script) filesize in the SPL header Bernhard Nortmann
2016-06-05 11:44 ` Siarhei Siamashka
2016-06-05 13:01 ` Bernhard Nortmann
2016-06-06 9:20 ` Siarhei Siamashka
2016-06-07 14:09 ` Bernhard Nortmann
2016-06-07 17:14 ` Siarhei Siamashka
2016-06-08 18:23 ` [U-Boot] [PATCH v2] sunxi: Add the ability to recognize and auto-import uEnv-style data Bernhard Nortmann
2016-06-08 20:13 ` Hans de Goede
2016-06-08 21:29 ` Bernhard Nortmann
2016-06-09 0:14 ` Siarhei Siamashka
2016-06-09 5:37 ` [U-Boot] [PATCH v3] sunxi: FEL - " Bernhard Nortmann
2016-06-10 19:31 ` [U-Boot] [U-Boot, " Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739996A.7090806@web.de \
--to=bernhard.nortmann@web.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox