public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] scsi: add PCIe to sata converter Marvell chip 88SE9170
Date: Mon, 16 May 2016 09:02:55 -0700	[thread overview]
Message-ID: <5739EF2F.8060006@nxp.com> (raw)
In-Reply-To: <1460545185-30767-1-git-send-email-po.liu@nxp.com>

On 04/13/2016 04:09 AM, Po Liu wrote:
> Add to the command scsi device list.
> 
> Signed-off-by: Po Liu <po.liu@nxp.com>
> ---
>  cmd/scsi.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/cmd/scsi.c b/cmd/scsi.c
> index 8991125..c85fefc 100644
> --- a/cmd/scsi.c
> +++ b/cmd/scsi.c
> @@ -31,6 +31,11 @@
>  #define SCSI_VEND_ID 0x10b9
>  #define SCSI_DEV_ID  0x5288
>  
> +#elif defined CONFIG_SATA_88SE9170
> +
> +#define SCSI_VEND_ID 0x1b4b
> +#define SCSI_DEV_ID  0x9170
> +
>  #elif !defined(CONFIG_SCSI_AHCI_PLAT)
>  #error no scsi device defined
>  #endif
> 

Po,

Would it be a better idea to define CONFIG_SCSI_DEV_LIST in your board header
file? You can merge your two patches into one.

York

  reply	other threads:[~2016-05-16 16:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13 10:59 [U-Boot] [PATCH 1/2] scsi: add PCIe to sata converter Marvell chip 88SE9170 Po Liu
2016-05-16 16:02 ` York Sun [this message]
2016-05-17  1:02   ` Po Liu
2016-05-18  2:09 ` [U-Boot] [PATCH] ls1043ardb: add support scsi command and pcie to sata converter Po Liu
2016-05-24 17:22   ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5739EF2F.8060006@nxp.com \
    --to=york.sun@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox