public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] powerpc/mpc85xx: T104x: Add nand secure boot target
Date: Tue, 17 May 2016 08:11:37 -0700	[thread overview]
Message-ID: <573B34A9.3020008@nxp.com> (raw)
In-Reply-To: <1459517037-16833-2-git-send-email-sumit.garg@nxp.com>

On 04/01/2016 12:09 AM, Sumit Garg wrote:
> For mpc85xx SoCs, the core begins execution from address 0xFFFFFFFC.
> In non-secure boot scenario from NAND, this address will map to CPC
> configured as SRAM. But in case of secure boot, this default address
> always maps to IBR (Internal Boot ROM).
> The IBR code requires that the bootloader(U-boot) must lie in 0 to 3.5G
> address space i.e. 0x0 - 0xDFFFFFFF.
> 
> For secure boot target from NAND, the text base for SPL is kept same as
> non-secure boot target i.e. 0xFFFx_xxxx but the SPL U-boot binary will
> be copied to CPC configured as SRAM with address in 0-3.5G(0xBFFC_0000)
> As a the virtual and physical address of CPC would be different. The
> virtual address 0xFFFx_xxxx needs to be mapped to physical address
> 0xBFFx_xxxx.
> 
> Create a new PBI file to configure CPC as SRAM with address 0xBFFC0000
> and update DCFG SCRTACH1 register with location of Header required for
> secure boot.
> 
> The changes are similar to
> commit 467a40dfe35f48d830f01a72617207d03ca85b4d
>     powerpc/mpc85xx: SECURE BOOT- NAND secure boot target for P3041
> 
> While P3041 has a 1MB CPC and does not require SPL. On T104x, CPC
> is only 256K and thus SPL framework is used.
> The changes are only applicable for SPL U-Boot running out of CPC SRAM
> and not the next level U-Boot loaded on DDR.
> 
> Reviewed-by: Ruchika Gupta <ruchika.gupta@nxp.com>
> Signed-off-by: Aneesh Bansal <aneesh.bansal@nxp.com>
> Signed-off-by: Sumit Garg <sumit.garg@nxp.com>
> ---
>  arch/powerpc/cpu/mpc85xx/cpu_init.c            |  4 +--
>  arch/powerpc/cpu/mpc85xx/start.S               | 11 ++++++--
>  arch/powerpc/include/asm/fsl_secure_boot.h     | 10 ++++++-
>  board/freescale/t104xrdb/t104x_pbi_sb.cfg      | 38 ++++++++++++++++++++++++++
>  board/freescale/t104xrdb/tlb.c                 | 15 +++++++++-
>  configs/T1042RDB_PI_NAND_SECURE_BOOT_defconfig | 11 ++++++++
>  include/configs/T104xRDB.h                     | 29 +++++++++++++++++++-
>  7 files changed, 110 insertions(+), 8 deletions(-)
>  create mode 100644 board/freescale/t104xrdb/t104x_pbi_sb.cfg
>  create mode 100644 configs/T1042RDB_PI_NAND_SECURE_BOOT_defconfig
> 

Sumit,

Please rebase your patch to latest master branch. I am seeing compiling errors
due to upstream changes.

Thanks.

York

  reply	other threads:[~2016-05-17 15:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 13:23 [U-Boot] [PATCH 1/2] powerpc/mpc85xx: SECURE BOOT- Enable chain of trust in SPL Sumit Garg
2016-04-01 13:23 ` [U-Boot] [PATCH 2/2] powerpc/mpc85xx: T104x: Add nand secure boot target Sumit Garg
2016-05-17 15:11   ` York Sun [this message]
2016-05-18  8:34     ` Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573B34A9.3020008@nxp.com \
    --to=york.sun@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox