From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] arm64: optimize __asm_{flush, invalidate}_dcache_all
Date: Tue, 17 May 2016 08:32:24 -0700 [thread overview]
Message-ID: <573B3988.7030704@nxp.com> (raw)
In-Reply-To: <1463470688-13772-2-git-send-email-yamada.masahiro@socionext.com>
On 05/17/2016 12:37 AM, Masahiro Yamada wrote:
> __asm_dcache_all can directly return to the caller of
> __asm_{flush,invalidate}_dcache_all.
>
> We do not have to waste x16 register here.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm/cpu/armv8/cache.S | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/cpu/armv8/cache.S b/arch/arm/cpu/armv8/cache.S
> index a9f4fec..1c71a2f 100644
> --- a/arch/arm/cpu/armv8/cache.S
> +++ b/arch/arm/cpu/armv8/cache.S
> @@ -104,19 +104,13 @@ finished:
> ENDPROC(__asm_dcache_all)
>
> ENTRY(__asm_flush_dcache_all)
> - mov x16, lr
> mov x0, #0
> - bl __asm_dcache_all
> - mov lr, x16
> - ret
> + b __asm_dcache_all
> ENDPROC(__asm_flush_dcache_all)
>
> ENTRY(__asm_invalidate_dcache_all)
> - mov x16, lr
> mov x0, #0x1
> - bl __asm_dcache_all
> - mov lr, x16
> - ret
> + b __asm_dcache_all
> ENDPROC(__asm_invalidate_dcache_all)
>
> /*
>
It is a smart solution.
Reviewed-by: York Sun <york.sun@nxp.com>
next prev parent reply other threads:[~2016-05-17 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 7:38 [U-Boot] [PATCH 0/3] arm64: minor fixes of cache operation routine Masahiro Yamada
2016-05-17 7:38 ` [U-Boot] [PATCH 1/3] arm64: optimize __asm_{flush, invalidate}_dcache_all Masahiro Yamada
2016-05-17 15:32 ` York Sun [this message]
2016-05-30 18:05 ` [U-Boot] [U-Boot, " Tom Rini
2016-05-17 7:38 ` [U-Boot] [PATCH 2/3] arm64: fix comment "flush & invalidate" Masahiro Yamada
2016-05-30 18:05 ` [U-Boot] [U-Boot,2/3] " Tom Rini
2016-05-17 7:38 ` [U-Boot] [PATCH 3/3] arm64: rename __asm_flush_dcache_level to __asm_dcache_level Masahiro Yamada
2016-05-30 18:06 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573B3988.7030704@nxp.com \
--to=york.sun@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox