public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot-release] [PATCH 06/10][v3] armv8: fsl-layerscape: Add support of QorIQ LS1012A SoC
Date: Tue, 17 May 2016 09:52:09 -0700	[thread overview]
Message-ID: <573B4C39.2080609@nxp.com> (raw)
In-Reply-To: <DB5PR0401MB1717327738EF99058100C38A99480@DB5PR0401MB1717.eurprd04.prod.outlook.com>

On 05/17/2016 09:35 AM, Edward L Swarthout wrote:
> From: Prabhakar Kushwaha:
>> --- a/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch2_speed.c
>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/fsl_lsch2_speed.c
>> 	unsigned int cpu;
>> +	unsigned int svr, ver;
>> 	const u8 core_cplx_pll[8] = {
> ...
>> -			FSL_CHASSIS2_RCWSR0_MEM_PLL_RAT_MASK;
>> +	svr = gur_in32(&gur->svr);
>> +	ver = SVR_SOC_VER(svr);
>> +	if (ver == SVR_LS1012) {
>> +		sys_info->freq_ddrbus *= (gur_in32(&gur->rcwsr[0]) >>
>> +				FSL_CHASSIS2_RCWSR0_SYS_PLL_RAT_SHIFT) &
>> +				FSL_CHASSIS2_RCWSR0_SYS_PLL_RAT_MASK;
>> +	} else {
>> +		sys_info->freq_systembus *= (gur_in32(&gur->rcwsr[0]) >>
>> +				FSL_CHASSIS2_RCWSR0_SYS_PLL_RAT_SHIFT) &
>> +				FSL_CHASSIS2_RCWSR0_SYS_PLL_RAT_MASK;
> 
> Why introduce a run-time check for every board when this could be handled at compile time?
> 

Ed,

Do you mean the platform PLL is fixed and not controlled by RCW?

York

  reply	other threads:[~2016-05-17 16:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-14  8:31 [U-Boot] [PATCH 00/10][v3] armv8: fsl-layerscape: Add support of LS1012A SoC and platform Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 01/10][v3] armv8: fsl-layerscape: Put SMMU config code in SMMU_BASE Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 02/10][v3] armv8: fsl-layerscape: Avoid LS1043A specifc defines Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 03/10][v3] driver: mtd: spi: Adding support for QSPI flash Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 04/10][v3] armv8: fsl-layerscape: fix compile warning "rcw_tmp" Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 05/10][v3] armv8: fsl-layerscape: Organize SoC overview at common location Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 06/10][v3] armv8: fsl-layerscape: Add support of QorIQ LS1012A SoC Prabhakar Kushwaha
2016-05-17 16:35   ` [U-Boot] [u-boot-release] " Edward L Swarthout
2016-05-17 16:52     ` York Sun [this message]
2016-05-17 19:47       ` Edward L Swarthout
2016-05-17 20:33         ` York Sun
2016-05-18  9:07           ` Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 07/10][v3] board: freescale: common: Conditionally compile IFC QXIS func Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 08/10][v3] board: freescale: common: Add flag for LBMAP brdcfg reg offset Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 09/10][v3] armv8: ls1012a: Add support of ls1012aqds board Prabhakar Kushwaha
2016-05-27 16:03   ` York Sun
2016-05-28  0:51     ` Prabhakar Kushwaha
2016-05-14  8:31 ` [U-Boot] [PATCH 10/10][v3] armv8: ls1012a: Add support of ls1012ardb board Prabhakar Kushwaha
2016-05-14 18:14   ` Alexander Graf
2016-05-28  1:02     ` Prabhakar Kushwaha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573B4C39.2080609@nxp.com \
    --to=york.sun@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox