public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] SPL: FIT: Enable SPL_FIT_LOAD in RAM based boot mode
Date: Wed, 18 May 2016 17:22:25 +0200	[thread overview]
Message-ID: <573C88B1.1090001@xilinx.com> (raw)
In-Reply-To: <573C8667.10005@ti.com>

On 18.5.2016 17:12, Lokesh Vutla wrote:
> 
> 
> On 5/17/2016 10:30 PM, Michal Simek wrote:
>> Support loading FIT in SPL for RAM bootmode.
>> CONFIG_SPL_LOAD_FIT_ADRESS points to address where FIT image is stored
>> in memory.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> Changes in v2:
>> - Fix empty line
>> - Fix addr name and remove SPL_LOAD_FIT macro
>>
>>   common/spl/spl.c | 45 ++++++++++++++++++++++++++++++++++++---------
>>   1 file changed, 36 insertions(+), 9 deletions(-)
>>
>> diff --git a/common/spl/spl.c b/common/spl/spl.c
>> index 0fc5b058be31..3faa751e4b43 100644
>> --- a/common/spl/spl.c
>> +++ b/common/spl/spl.c
>> @@ -136,20 +136,47 @@ __weak void __noreturn
>> jump_to_image_no_args(struct spl_image_info *spl_image)
>>       image_entry();
>>   }
>>
>> +#ifndef CONFIG_SPL_LOAD_FIT_ADDRESS
>> +# define CONFIG_SPL_LOAD_FIT_ADDRESS    0
>> +#endif
>> +
> 
> May be a good idea to default this to CONFIG_SYS_TEXT_BASE instead of 0?

The problem is that if u-boot is in FIT that it will be loaded to
TEXT_BASE address.
Maybe easier to just don't define any value which end up in compilation
error.

Thanks,
Michal

  reply	other threads:[~2016-05-18 15:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17 17:00 [U-Boot] [PATCH v2] SPL: FIT: Enable SPL_FIT_LOAD in RAM based boot mode Michal Simek
2016-05-18 15:12 ` Lokesh Vutla
2016-05-18 15:22   ` Michal Simek [this message]
2016-05-18 16:50     ` Lokesh Vutla
2016-05-19 16:15 ` Andreas Dannenberg
2016-05-19 16:38   ` Michal Simek
2016-05-19 18:16     ` Andreas Dannenberg
2016-05-19 18:33       ` Michal Simek
2016-05-19 19:26         ` Andreas Dannenberg
2016-05-20  6:05           ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573C88B1.1090001@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox