From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lokesh Vutla Date: Wed, 18 May 2016 22:20:11 +0530 Subject: [U-Boot] [PATCH v2] SPL: FIT: Enable SPL_FIT_LOAD in RAM based boot mode In-Reply-To: <573C88B1.1090001@xilinx.com> References: <8e3d705c04c22e79959554093678775cdd84b4e3.1463504422.git.michal.simek@xilinx.com> <573C8667.10005@ti.com> <573C88B1.1090001@xilinx.com> Message-ID: <573C9D43.1090200@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 5/18/2016 8:52 PM, Michal Simek wrote: > On 18.5.2016 17:12, Lokesh Vutla wrote: >> >> >> On 5/17/2016 10:30 PM, Michal Simek wrote: >>> Support loading FIT in SPL for RAM bootmode. >>> CONFIG_SPL_LOAD_FIT_ADRESS points to address where FIT image is stored >>> in memory. >>> >>> Signed-off-by: Michal Simek >>> Reviewed-by: Simon Glass >>> --- >>> >>> Changes in v2: >>> - Fix empty line >>> - Fix addr name and remove SPL_LOAD_FIT macro >>> >>> common/spl/spl.c | 45 ++++++++++++++++++++++++++++++++++++--------- >>> 1 file changed, 36 insertions(+), 9 deletions(-) >>> >>> diff --git a/common/spl/spl.c b/common/spl/spl.c >>> index 0fc5b058be31..3faa751e4b43 100644 >>> --- a/common/spl/spl.c >>> +++ b/common/spl/spl.c >>> @@ -136,20 +136,47 @@ __weak void __noreturn >>> jump_to_image_no_args(struct spl_image_info *spl_image) >>> image_entry(); >>> } >>> >>> +#ifndef CONFIG_SPL_LOAD_FIT_ADDRESS >>> +# define CONFIG_SPL_LOAD_FIT_ADDRESS 0 >>> +#endif >>> + >> >> May be a good idea to default this to CONFIG_SYS_TEXT_BASE instead of 0? > > The problem is that if u-boot is in FIT that it will be loaded to > TEXT_BASE address. > Maybe easier to just don't define any value which end up in compilation > error. Yeah, you were right. Initially I was thinking there won't be a problem overriding the data. You can leave it as is. Thanks and regards, Lokesh > > Thanks, > Michal >