From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option
Date: Thu, 19 May 2016 07:22:54 +0200 [thread overview]
Message-ID: <573D4DAE.2040909@denx.de> (raw)
In-Reply-To: <20160519025745.GJ24777@vireshk-i7>
Hello Viresh,
Am 19.05.2016 um 04:59 schrieb Viresh Kumar:
> Sorry, I had to drop the extremely long cc list, otherwise I wasn't
> able to reply to this email. Mutt was rejecting it for some reason.
>
> Any anyway, you should have put all those people in bcc rather.
Sorry for that ... I used patman and forgot the "-m" no maintainer
option ... Hmmm... on the other side, all involved people should be
informed ... added Simon to Cc ... Simon?
patman may create a big cc list, for example when moving config options
to Kconfig ...
Makes it sense to add them all into bcc? At least the ones the
maintainer script finds?
Is this easy to adapt in patman?
Hmm.. a problem is may "git send-mail", as there is no "--bcc-cmd" option ...
So, all bcc addresses must be added with the "--bcc=address" option ...
> On 18-05-16, 16:18, Heiko Schocher wrote:
>> diff --git a/include/configs/spear-common.h b/include/configs/spear-common.h
>> index c4b6234..5e2e2b1 100644
>> --- a/include/configs/spear-common.h
>> +++ b/include/configs/spear-common.h
>> @@ -106,9 +106,7 @@
>> * Default Environment Varible definitions
>> */
>> #if defined(CONFIG_SPEAR_USBTTY)
>> -#define CONFIG_BOOTDELAY -1
>> #else
>> -#define CONFIG_BOOTDELAY 1
>> #endif
>
> Doesn't this ifdef look strange now ? :)
Indeed ... I have no such hw ... could you prepare a patch, which moves
CONFIG_SPEAR_USBTTY to Kconfig, so if this option is selected, it
set CONFIG_BOOTDELAY to -1 ?
OK ... looking into the code ...
$ grep -lr CONFIG_SPEAR_USBTTY include/
include/configs/spear-common.h
include/configs/spear6xx_evb.h
include/configs/spear3xx_evb.h
$
In include/configs/spear3xx_evb.h and include/configs/spear6xx_evb.h:
#if defined(CONFIG_usbtty)
#define CONFIG_SPEAR_USBTTY
#endif
Grrr... ugly style: CONFIG_usbtty
$ grep -lr CONFIG_usbtty .
./include/configs/spear6xx_evb.h
./include/configs/spear3xx_evb.h
$
Hmm... did not find CONFIG_usbtty somewhere defined ... is this is all
dead code?
So, in the first step I want to remove the lines
#if defined(CONFIG_SPEAR_USBTTY)
-#define CONFIG_BOOTDELAY -1
#else
-#define CONFIG_BOOTDELAY 1
#endif
in include/configs/spear-common.h complete. But there are more
places in this file with a "#if defined(CONFIG_SPEAR_USBTTY)" ...
As it is currently dead code in mainline ... it needs a cleanup.
I remove the above lines in a v2 version of my patch. Done. Waiting
for more comments on this patch, before posting.
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2016-05-19 5:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 14:18 [U-Boot] [PATCH v1 00/12] am335x: add support for the am335x based bosch shc board Heiko Schocher
2016-05-18 14:18 ` [U-Boot] [PATCH v1 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option Heiko Schocher
2016-05-18 16:29 ` Stephen Warren
2016-05-19 2:59 ` Viresh Kumar
2016-05-19 5:22 ` Heiko Schocher [this message]
2016-05-19 5:46 ` Viresh Kumar
2016-05-20 13:09 ` Tom Rini
2016-05-20 13:19 ` Daniel Schwierzeck
2016-05-20 15:24 ` Tom Rini
2016-05-18 14:18 ` [U-Boot] [PATCH v1 02/12] tests: py: disable main_signon check for printenv cmd Heiko Schocher
2016-05-18 16:37 ` Stephen Warren
2016-06-16 17:09 ` Stephen Warren
2016-05-18 14:18 ` [U-Boot] [PATCH v1 03/12] power, tps65217: add some defines Heiko Schocher
2016-05-20 19:48 ` Tom Rini
2016-05-18 14:18 ` [U-Boot] [PATCH v1 04/12] arm, am335x: add some missing GPIO register definitions Heiko Schocher
2016-05-20 19:48 ` Tom Rini
2016-05-18 14:18 ` [U-Boot] [PATCH v1 05/12] am335x: add some missing CM_CLKMODE_DPLL_SSC macros Heiko Schocher
2016-05-20 19:48 ` Tom Rini
2016-05-18 14:18 ` [U-Boot] [PATCH v1 06/12] arm, am335x: Enable Spread Spectrum for the MPU Heiko Schocher
2016-05-20 19:48 ` Tom Rini
2016-05-18 14:18 ` [U-Boot] [PATCH v1 07/12] bootstage: call show_boot_progress also in SPL Heiko Schocher
2016-05-19 4:02 ` Simon Glass
2016-05-18 14:18 ` [U-Boot] [PATCH v1 08/12] mmc: revert mmc: Handle switch error status bit in MMC card status Heiko Schocher
2016-05-18 14:18 ` [U-Boot] [PATCH v1 09/12] mmc: omap_hsmmc: enable 8bit interface for eMMC for AM33xx Heiko Schocher
2016-05-20 19:49 ` Tom Rini
2016-05-18 14:18 ` [U-Boot] [PATCH v1 10/12] armv7: omap-common: make SPL board_mmc_init() weak Heiko Schocher
2016-05-18 14:18 ` [U-Boot] [PATCH v1 11/12] doc, spl, am335x: update am335x-network Heiko Schocher
2016-05-20 19:49 ` Tom Rini
2016-05-18 14:18 ` [U-Boot] [PATCH v1 12/12] am335x, shc: add support for the am335x based bosch shc board Heiko Schocher
2016-05-20 19:49 ` Tom Rini
2016-05-23 12:56 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573D4DAE.2040909@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox