From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: ipu: Fix build with hard-float ARM toolchain
Date: Thu, 19 May 2016 12:27:00 +0200 [thread overview]
Message-ID: <573D94F4.8050605@denx.de> (raw)
In-Reply-To: <573D6DF1.7070708@free.fr>
Hi Guillaume,
On 19/05/2016 09:40, Guillaume Gardet wrote:
>
>
> Le 19/05/2016 03:09, Peng Fan a ?crit :
>> Hi Guillaume,
>>
>> On Wed, May 18, 2016 at 02:19:43PM +0200, Guillaume GARDET wrote:
>>> Build with hard-float ARM toolchain was broken by commit 3cb4f25c:
>>> 'video: ipu: avoid overflow issue'.
>>> To fix it, we use do_div function.
>>>
>>> Build tested for mx6qsabrelite_defconfig.
>>>
>>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>>> Cc: Peng Fan <van.freenix@gmail.com>
>>> Cc: Sandor Yu <sandor.yu@nxp.com>
>>> Cc: Anatolij Gustschin <agust@denx.de>
>>> Cc: Stefano Babic <sbabic@denx.de>
>>> Cc: Fabio Estevam <fabio.estevam@nxp.com>
>>> Cc: Tom Rini <trini@konsulko.com>
>>>
>>> ---
>>> drivers/video/ipu_common.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/video/ipu_common.c b/drivers/video/ipu_common.c
>>> index 36d4b23..e319c82 100644
>>> --- a/drivers/video/ipu_common.c
>>> +++ b/drivers/video/ipu_common.c
>>> @@ -352,7 +352,8 @@ static int ipu_pixel_clk_set_rate(struct clk
>>> *clk, unsigned long rate)
>>> */
>>> __raw_writel((div / 16) << 16, DI_BS_CLKGEN1(clk->id));
>>>
>>> - clk->rate = (u64)(clk->parent->rate * 16) / div;
>>> + do_div(parent_rate, div);
>>> + clk->rate = parent_rate;
>> This issue was already fixed,.
>> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=c510f2e436008e55a50b063f2180cb1e63984224
>>
>
> Ok. Sorry, I did not checked u-boot-imx git repo.
> Do you know why it was not included in the v2016.05 release?
No reason, it was simply missed :-(
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2016-05-19 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 12:19 [U-Boot] [PATCH] video: ipu: Fix build with hard-float ARM toolchain Guillaume GARDET
2016-05-19 1:09 ` Peng Fan
2016-05-19 7:40 ` Guillaume Gardet
2016-05-19 10:27 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573D94F4.8050605@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox