From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] driver/ddr/fsl: Force enabling parity for A-009803
Date: Fri, 20 May 2016 08:29:13 -0700 [thread overview]
Message-ID: <573F2D49.9050102@nxp.com> (raw)
In-Reply-To: <1463731546-15232-1-git-send-email-Shengzhou.Liu@nxp.com>
On 05/20/2016 01:15 AM, Shengzhou Liu wrote:
> Default address parity is disabled for DDR4 UDIMM for considing
> performance, it needs to enable parity for A-009803 workaround.
>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@nxp.com>
> ---
> drivers/ddr/fsl/options.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/ddr/fsl/options.c b/drivers/ddr/fsl/options.c
> index d0075ff..dcef0bb 100644
> --- a/drivers/ddr/fsl/options.c
> +++ b/drivers/ddr/fsl/options.c
> @@ -1016,6 +1016,9 @@ unsigned int populate_memctl_options(const common_timing_params_t *common_dimm,
> }
> }
>
> +#ifdef CONFIG_SYS_FSL_ERRATUM_A009803
> + popts->ap_en = 1;
> +#endif
> /*
> * BSTTOPRE precharge interval
> *
>
Shengzhou,
It looks backward. You should detect if the condition is right before applying
the workaround, not by forcing the condition.
York
next prev parent reply other threads:[~2016-05-20 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 8:05 [U-Boot] [PATCH] driver/ddr/fsl: Force enabling parity for A-009803 Shengzhou Liu
2016-05-20 15:29 ` York Sun [this message]
2016-05-23 9:18 ` Shengzhou Liu
2016-05-23 15:33 ` York Sun
2016-05-24 5:15 ` Shengzhou Liu
2016-05-24 16:13 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573F2D49.9050102@nxp.com \
--to=york.sun@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox