From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <york.sun@nxp.com>
Date: Fri, 20 May 2016 08:29:13 -0700
Subject: [U-Boot] [PATCH] driver/ddr/fsl: Force enabling parity for
	A-009803
In-Reply-To: <1463731546-15232-1-git-send-email-Shengzhou.Liu@nxp.com>
References: <1463731546-15232-1-git-send-email-Shengzhou.Liu@nxp.com>
Message-ID: <573F2D49.9050102@nxp.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/20/2016 01:15 AM, Shengzhou Liu wrote:
> Default address parity is disabled for DDR4 UDIMM for considing
> performance, it needs to enable parity for A-009803 workaround.
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@nxp.com>
> ---
>  drivers/ddr/fsl/options.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ddr/fsl/options.c b/drivers/ddr/fsl/options.c
> index d0075ff..dcef0bb 100644
> --- a/drivers/ddr/fsl/options.c
> +++ b/drivers/ddr/fsl/options.c
> @@ -1016,6 +1016,9 @@ unsigned int populate_memctl_options(const common_timing_params_t *common_dimm,
>  		}
>  	}
>  
> +#ifdef CONFIG_SYS_FSL_ERRATUM_A009803
> +	popts->ap_en = 1;
> +#endif
>  	/*
>  	 * BSTTOPRE precharge interval
>  	 *
> 

Shengzhou,

It looks backward. You should detect if the condition is right before applying
the workaround, not by forcing the condition.

York