From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 02/12] spi: davinci_spi: Convert to driver to adapt to DM
Date: Tue, 24 May 2016 09:56:04 +0530 [thread overview]
Message-ID: <5743D7DC.9010603@ti.com> (raw)
In-Reply-To: <CAPnjgZ0DRx1d9_j1rccKGPhU1JXPy8hZO0001=sDe+f1obQMBw@mail.gmail.com>
On 05/20/2016 08:54 PM, Simon Glass wrote:
> Hi Vignesh,
>
> On 19 May 2016 at 23:01, Vignesh R <vigneshr@ti.com> wrote:
>>
>> Convert davinci_spi driver so that it complies with SPI DM framework.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>> ---
>>
>> v5: correct error message.
>>
>> v4: Check error returned by dev_map_physmem().
>>
>> v3: No changes
>>
>> v2: Add comments to struct davinci_spi_slave members.
>> Use dev_map_physmem() added by previous patch.
>>
>> drivers/spi/davinci_spi.c | 329 +++++++++++++++++++++++++++++++++-------------
>> 1 file changed, 240 insertions(+), 89 deletions(-)
>
> Sorry I missed something below.
> [snip]
>
>> +static int davinci_ofdata_to_platadata(struct udevice *bus)
>> +{
>> + struct davinci_spi_slave *ds = dev_get_priv(bus);
>> + const void *blob = gd->fdt_blob;
>> + int node = bus->of_offset;
>> +
>> + ds->regs = dev_map_physmem(bus, sizeof(struct davinci_spi_regs));
>> + if (!ds->regs) {
>> + printf("%s: could not map device address\n", __func__);
>> + return -ENODEV;
>
> -EINVAL
>
> We use -ENODEV to say there is no device. Here, we have a device but
> the configuration is wrong.
Ok, I posted in v6 with above change.
--
Regards
Vignesh
next prev parent reply other threads:[~2016-05-24 4:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 11:19 [U-Boot] [PATCH v3 00/12] Convert davinci_spi to DM Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 01/12] dm: core: implement dev_map_phsymem() Vignesh R
2016-05-05 17:44 ` Jagan Teki
2016-05-06 3:58 ` [U-Boot] [PATCH v4] " Vignesh R
2016-05-06 15:30 ` Jagan Teki
2016-05-06 15:46 ` R, Vignesh
2016-05-06 16:30 ` Jagan Teki
2016-05-09 4:09 ` Vignesh R
2016-05-14 19:34 ` [U-Boot] [PATCH v3 01/12] " Simon Glass
2016-05-16 9:18 ` Vignesh R
2016-05-16 9:16 ` [U-Boot] [PATCH v5] dm: core: implement dev_map_physmem() Vignesh R
2016-05-19 4:02 ` Simon Glass
2016-05-04 11:19 ` [U-Boot] [PATCH v3 02/12] spi: davinci_spi: Convert to driver to adapt to DM Vignesh R
2016-05-06 17:49 ` Tom Rini
2016-05-16 9:38 ` [U-Boot] [PATCH v4 " Vignesh R
2016-05-20 15:23 ` Simon Glass
2016-05-20 5:01 ` [U-Boot] [PATCH v5 " Vignesh R
2016-05-20 15:24 ` Simon Glass
2016-05-24 4:26 ` Vignesh R [this message]
2016-05-24 4:24 ` [U-Boot] [PATCH v6 " Vignesh R
2016-06-16 10:42 ` Vignesh R
2016-06-16 23:29 ` Simon Glass
2016-05-04 11:19 ` [U-Boot] [PATCH v3 03/12] keystone2: spi: do not define DM_SPI and DM_SPI_FLASH for SPL build Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 04/12] ARM: dts: keystone2: add SPI aliases for davinci SPI nodes Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 05/12] ARM: dts: k2hk: Enable Davinci SPI controller Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 06/12] defconfig: k2hk_evm_defconfig: enable SPI driver model Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 07/12] ARM: dts: k2e: Enable Davinci SPI controller Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 08/12] defconfig: k2e_evm_defconfig: enable SPI driver model Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 09/12] ARM: dts: k2l: Enable Davinci SPI controller Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 10/12] defconfig: k2l_evm_defconfig: enable SPI driver model Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 11/12] ARM: dts: k2g: add support for Davinci SPI controller Vignesh R
2016-05-04 11:19 ` [U-Boot] [PATCH v3 12/12] defconfig: k2g_evm_defconfig: enable SPI driver model Vignesh R
2016-05-05 18:02 ` [U-Boot] [PATCH v3 00/12] Convert davinci_spi to DM Jagan Teki
2016-06-01 13:43 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5743D7DC.9010603@ti.com \
--to=vigneshr@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox