public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: mx6qsabreauto: drop duplicated net phy configuration
Date: Tue, 24 May 2016 14:34:47 +0200	[thread overview]
Message-ID: <57444A67.5000907@denx.de> (raw)
In-Reply-To: <1464092927-3044-1-git-send-email-van.freenix@gmail.com>

On 24/05/2016 14:28, Peng Fan wrote:
> In 'commit d584c68ce0f5bf2f430ccfb2ba00bd506206fb91',
> ar8031 is changed to use ar8035_config. ar8035_config
> actually does the same thing as mx6_rgmii_rework, so
> drop mx6_rgmii_rework and board_phy_config.
> 
> Signed-off-by: Peng Fan <van.freenix@gmail.com>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>  board/freescale/mx6qsabreauto/mx6qsabreauto.c | 33 ---------------------------
>  1 file changed, 33 deletions(-)
> 
> diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> index 0712f08..d63a979 100644
> --- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> +++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
> @@ -321,39 +321,6 @@ static void setup_gpmi_nand(void)
>  }
>  #endif
>  
> -int mx6_rgmii_rework(struct phy_device *phydev)
> -{
> -	unsigned short val;
> -
> -	/* To enable AR8031 ouput a 125MHz clk from CLK_25M */
> -	phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x7);
> -	phy_write(phydev, MDIO_DEVAD_NONE, 0xe, 0x8016);
> -	phy_write(phydev, MDIO_DEVAD_NONE, 0xd, 0x4007);
> -
> -	val = phy_read(phydev, MDIO_DEVAD_NONE, 0xe);
> -	val &= 0xffe3;
> -	val |= 0x18;
> -	phy_write(phydev, MDIO_DEVAD_NONE, 0xe, val);
> -
> -	/* introduce tx clock delay */
> -	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x5);
> -	val = phy_read(phydev, MDIO_DEVAD_NONE, 0x1e);
> -	val |= 0x0100;
> -	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, val);
> -
> -	return 0;
> -}
> -
> -int board_phy_config(struct phy_device *phydev)
> -{
> -	mx6_rgmii_rework(phydev);
> -
> -	if (phydev->drv->config)
> -		phydev->drv->config(phydev);
> -
> -	return 0;
> -}
> -
>  static void setup_fec(void)
>  {
>  	if (is_mx6dqp()) {
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

      parent reply	other threads:[~2016-05-24 12:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 12:28 [U-Boot] [PATCH] imx: mx6qsabreauto: drop duplicated net phy configuration Peng Fan
2016-05-24 12:32 ` Fabio Estevam
2016-05-24 13:02   ` Peng Fan
2016-05-24 12:34 ` Stefano Babic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57444A67.5000907@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox