From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display
Date: Tue, 24 May 2016 16:07:37 +0200 [thread overview]
Message-ID: <57446029.3030803@denx.de> (raw)
In-Reply-To: <1463746931-7440-1-git-send-email-andrew.shadura@collabora.co.uk>
Hi Andrew,
On 20/05/2016 14:22, Andrew Shadura wrote:
> Don't try to configure the backlight when CONFIG_VIDEO_IPUV3 isn't set.
>
> Signed-off-by: Andrew Shadura <andrew.shadura@collabora.co.uk>
> ---
> board/ge/bx50v3/bx50v3.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c
> index e167cd5..fb112ee 100644
> --- a/board/ge/bx50v3/bx50v3.c
> +++ b/board/ge/bx50v3/bx50v3.c
> @@ -601,6 +601,8 @@ int board_late_init(void)
> #ifdef CONFIG_CMD_BMODE
> add_board_boot_modes(board_boot_modes);
> #endif
> +
> +#ifdef CONFIG_VIDEO_IPUV3
> /* We need at least 200ms between power on and backlight on
> * as per specifications from CHI MEI */
> mdelay(250);
> @@ -615,6 +617,7 @@ int board_late_init(void)
> gpio_direction_output(LVDS_BACKLIGHT_GP, 1);
>
> pwm_enable(0);
> +#endif
...but CONFIG_VIDEO_IPUV3 is set in include/configs/ge_bx50v3.h, that
means your changes works on a out-of-tree version of the board.
To get this real working, you need to set CONFIG_VIDEO_IPUV3 via
menuconfig, that is outside ge_bx50v3.h.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2016-05-24 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 12:22 [U-Boot] [PATCH] board: ge: bx50v3: don't configure the backlight when there's no display Andrew Shadura
2016-05-24 14:07 ` Stefano Babic [this message]
2016-05-24 14:09 ` Andrew Shadura
2016-05-24 15:26 ` Stefano Babic
2016-05-24 15:28 ` Andrew Shadura
2016-05-24 15:33 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57446029.3030803@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox