[U-Boot] [PATCH] net: Add ag7xxx driver for Atheros MIPS

Marek Vasut
2016-05-08T22:09:46Z

On 05/08/2016 11:25 PM, Amit Tomer wrote:
> Hello!

Hi!

>> +
>> +#define CONFIG_TX_DESCR_NUM 8
>> +#define CONFIG_RX_DESCR_NUM 8
>> +#define CONFIG_ETH_BUFSIZE 2048
>
> Isn't it too BIG size for normal ethernet frame, unless we need Jumbo Frame ?

It is the next larger power of two from the 1536B ethernet frame, which
has the benefit:
- The buffers are aligned to half the page size (on this machine)
- There is enough space of oversized packets (due to tags etc)
Jumbo frames are 9k, they are not supported by u-boot and won't fit anyway.

Given the size of DRAM on MIPS machines with this SoC, microoptimizing
here seems pointless to me.

> Thanks,
> Amit.
>

--
Best regards,
Marek Vasut