From: York Sun <york.sun@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 v2] driver/ddr/fsl: Add workaround for erratum A-009803
Date: Wed, 25 May 2016 09:42:06 -0700 [thread overview]
Message-ID: <5745D5DE.5020808@nxp.com> (raw)
In-Reply-To: <1457602617-968-2-git-send-email-Shengzhou.Liu@nxp.com>
On 03/10/2016 01:46 AM, Shengzhou Liu wrote:
> During initial DDR training, false parity errors may be detected.
> This patch adds workaround to fix the erratum.
> Tested on LS2085QDS and LS2080RDB.
>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@nxp.com>
> ---
> v2: Integrated York's comments.
>
> arch/arm/include/asm/arch-fsl-layerscape/config.h | 1 +
> drivers/ddr/fsl/fsl_ddr_gen4.c | 44 ++++++++++++++++++++---
> 2 files changed, 40 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> index 0ef7c9d..b0c112b 100644
> --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> @@ -119,6 +119,7 @@
> #define CONFIG_SYS_FSL_ERRATUM_A008751
> #define CONFIG_SYS_FSL_ERRATUM_A009635
> #define CONFIG_SYS_FSL_ERRATUM_A009663
> +#define CONFIG_SYS_FSL_ERRATUM_A009803
> #define CONFIG_SYS_FSL_ERRATUM_A009942
>
> /* ARM A57 CORE ERRATA */
> diff --git a/drivers/ddr/fsl/fsl_ddr_gen4.c b/drivers/ddr/fsl/fsl_ddr_gen4.c
> index 6f76980..608810d 100644
> --- a/drivers/ddr/fsl/fsl_ddr_gen4.c
> +++ b/drivers/ddr/fsl/fsl_ddr_gen4.c
> @@ -12,7 +12,8 @@
> #include <fsl_ddr.h>
> #include <fsl_errata.h>
>
> -#ifdef CONFIG_SYS_FSL_ERRATUM_A008511
> +#if defined(CONFIG_SYS_FSL_ERRATUM_A008511) | \
> + defined(CONFIG_SYS_FSL_ERRATUM_A009803)
Shengzhou,
I missed this error. It should be logic or "||", not bit or "|" here. Please fix
it with your latest patch for 9803.
York
next prev parent reply other threads:[~2016-05-25 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 9:36 [U-Boot] [PATCH 1/2 v2] driver/ddr/fsl: Add address parity support for DDR4 UDIMM/discrete Shengzhou Liu
2016-03-10 9:36 ` [U-Boot] [PATCH 2/2 v2] driver/ddr/fsl: Add workaround for erratum A-009803 Shengzhou Liu
2016-03-22 15:41 ` york sun
2016-05-25 16:42 ` York Sun [this message]
2016-03-22 15:40 ` [U-Boot] [PATCH 1/2 v2] driver/ddr/fsl: Add address parity support for DDR4 UDIMM/discrete york sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5745D5DE.5020808@nxp.com \
--to=york.sun@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox