public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] serial: 16550: Add JZ47xx support
Date: Thu, 26 May 2016 00:17:35 +0200	[thread overview]
Message-ID: <5746247F.9010600@gmail.com> (raw)
In-Reply-To: <1464135571-7113-1-git-send-email-marex@denx.de>



Am 25.05.2016 um 02:19 schrieb Marek Vasut:
> The Ingenic JZ47xx requires special bit (UART_EN) set in FCR register
> in order to work at all. Add this special case handling into the driver.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Paul Burton <paul.burton@imgtec.com>
> ---
>  drivers/serial/ns16550.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index 30ba0aa..1323881 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -50,6 +50,14 @@ DECLARE_GLOBAL_DATA_PTR;
>  #endif
>  #endif
>  
> +#ifdef CONFIG_ARCH_JZ47XX
> +#undef UART_FCRVAL
> +/* Ingenic JZ47xx SoCs require that a 'UART Module Enable' bit be set */
> +#define UART_FCR_UME		0x10
> +#define UART_FCRVAL (UART_FCR_FIFO_EN | UART_FCR_RXSR |	\
> +		     UART_FCR_TXSR | UART_FCR_UME)
> +#endif

I think this could be added as DT property

> +
>  #ifndef CONFIG_SYS_NS16550_IER
>  #define CONFIG_SYS_NS16550_IER  0x00
>  #endif /* CONFIG_SYS_NS16550_IER */
> 

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160526/54e01771/attachment.sig>

  reply	other threads:[~2016-05-25 22:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25  0:19 [U-Boot] [PATCH] serial: 16550: Add JZ47xx support Marek Vasut
2016-05-25 22:17 ` Daniel Schwierzeck [this message]
2016-05-25 22:21   ` Marek Vasut
2016-05-25 22:31     ` Daniel Schwierzeck
2016-05-25 22:35       ` Marek Vasut
2016-05-26 13:29         ` Simon Glass
2016-05-26 16:34           ` Marek Vasut
2016-05-26 16:44             ` Simon Glass
2016-05-26 16:47               ` Marek Vasut
2016-05-26 16:48                 ` Simon Glass
2016-05-26 16:53                   ` Marek Vasut
2016-05-26 17:07                     ` Simon Glass
2016-05-26 17:35                       ` Marek Vasut
2016-05-26 17:47                         ` Simon Glass
2016-05-26 17:01                   ` Marek Vasut
2016-05-26 11:46     ` Paul Burton
2016-05-26 12:05       ` Marek Vasut
2016-05-26 13:55         ` Paul Burton
2016-05-26 18:22           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5746247F.9010600@gmail.com \
    --to=daniel.schwierzeck@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox