* [U-Boot] [PATCH V2 1/7] mips: ath79: ar933x: Avoid warning with gcc5
@ 2016-05-22 3:59 Wills Wang
2016-05-22 11:15 ` Marek Vasut
2016-05-25 23:30 ` Daniel Schwierzeck
0 siblings, 2 replies; 4+ messages in thread
From: Wills Wang @ 2016-05-22 3:59 UTC (permalink / raw)
To: u-boot
GCC 5.3 report a warning: 'upper' and 'lower' may be used
uninitialized in this function [-Wmaybe-uninitialized].
Compiler might need explicit initializer.
Signed-off-by: Wills Wang <wills.wang@live.com>
---
arch/mips/mach-ath79/ar933x/ddr.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/mach-ath79/ar933x/ddr.c b/arch/mips/mach-ath79/ar933x/ddr.c
index 91452bc..7f20d34 100644
--- a/arch/mips/mach-ath79/ar933x/ddr.c
+++ b/arch/mips/mach-ath79/ar933x/ddr.c
@@ -268,6 +268,8 @@ void ddr_tap_tuning(void)
dir = 1;
tap = readl(regs + AR71XX_DDR_REG_TAP_CTRL0);
val = tap;
+ upper = tap;
+ lower = tap;
while (!done) {
err = 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [U-Boot] [PATCH V2 1/7] mips: ath79: ar933x: Avoid warning with gcc5
2016-05-22 3:59 [U-Boot] [PATCH V2 1/7] mips: ath79: ar933x: Avoid warning with gcc5 Wills Wang
@ 2016-05-22 11:15 ` Marek Vasut
2016-05-22 11:25 ` Wills Wang
2016-05-25 23:30 ` Daniel Schwierzeck
1 sibling, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2016-05-22 11:15 UTC (permalink / raw)
To: u-boot
On 05/22/2016 05:59 AM, Wills Wang wrote:
> GCC 5.3 report a warning: 'upper' and 'lower' may be used
> uninitialized in this function [-Wmaybe-uninitialized].
> Compiler might need explicit initializer.
>
> Signed-off-by: Wills Wang <wills.wang@live.com>
> ---
>
> arch/mips/mach-ath79/ar933x/ddr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/mach-ath79/ar933x/ddr.c b/arch/mips/mach-ath79/ar933x/ddr.c
> index 91452bc..7f20d34 100644
> --- a/arch/mips/mach-ath79/ar933x/ddr.c
> +++ b/arch/mips/mach-ath79/ar933x/ddr.c
> @@ -268,6 +268,8 @@ void ddr_tap_tuning(void)
> dir = 1;
> tap = readl(regs + AR71XX_DDR_REG_TAP_CTRL0);
> val = tap;
> + upper = tap;
> + lower = tap;
> while (!done) {
> err = 0;
>
>
So what's new in V2 here ?
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH V2 1/7] mips: ath79: ar933x: Avoid warning with gcc5
2016-05-22 11:15 ` Marek Vasut
@ 2016-05-22 11:25 ` Wills Wang
0 siblings, 0 replies; 4+ messages in thread
From: Wills Wang @ 2016-05-22 11:25 UTC (permalink / raw)
To: u-boot
On 05/22/2016 07:15 PM, Marek Vasut wrote:
> On 05/22/2016 05:59 AM, Wills Wang wrote:
>> GCC 5.3 report a warning: 'upper' and 'lower' may be used
>> uninitialized in this function [-Wmaybe-uninitialized].
>> Compiler might need explicit initializer.
>>
>> Signed-off-by: Wills Wang <wills.wang@live.com>
>> ---
>>
>> arch/mips/mach-ath79/ar933x/ddr.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/mips/mach-ath79/ar933x/ddr.c b/arch/mips/mach-ath79/ar933x/ddr.c
>> index 91452bc..7f20d34 100644
>> --- a/arch/mips/mach-ath79/ar933x/ddr.c
>> +++ b/arch/mips/mach-ath79/ar933x/ddr.c
>> @@ -268,6 +268,8 @@ void ddr_tap_tuning(void)
>> dir = 1;
>> tap = readl(regs + AR71XX_DDR_REG_TAP_CTRL0);
>> val = tap;
>> + upper = tap;
>> + lower = tap;
>> while (!done) {
>> err = 0;
>>
>>
> So what's new in V2 here ?
>
Capitalize the first letter in the sentence.
--
Best Regards
Wills
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH V2 1/7] mips: ath79: ar933x: Avoid warning with gcc5
2016-05-22 3:59 [U-Boot] [PATCH V2 1/7] mips: ath79: ar933x: Avoid warning with gcc5 Wills Wang
2016-05-22 11:15 ` Marek Vasut
@ 2016-05-25 23:30 ` Daniel Schwierzeck
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Schwierzeck @ 2016-05-25 23:30 UTC (permalink / raw)
To: u-boot
Am 22.05.2016 um 05:59 schrieb Wills Wang:
> GCC 5.3 report a warning: 'upper' and 'lower' may be used
> uninitialized in this function [-Wmaybe-uninitialized].
> Compiler might need explicit initializer.
>
> Signed-off-by: Wills Wang <wills.wang@live.com>
> ---
>
> arch/mips/mach-ath79/ar933x/ddr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
applied to u-boot-mips, thanks.
--
- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160526/07a28e47/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-25 23:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-22 3:59 [U-Boot] [PATCH V2 1/7] mips: ath79: ar933x: Avoid warning with gcc5 Wills Wang
2016-05-22 11:15 ` Marek Vasut
2016-05-22 11:25 ` Wills Wang
2016-05-25 23:30 ` Daniel Schwierzeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox