From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Thu, 26 May 2016 14:01:24 +0900
Subject: [U-Boot] [PATCH 2/2] ARM: exynos: Disable serial support in SPL
In-Reply-To: <57265D26.4030305@denx.de>
References: <1462055772-6419-1-git-send-email-marex@denx.de>
 <1462055772-6419-2-git-send-email-marex@denx.de>
 <20160501185720.GG7884@bill-the-cat> <57265D26.4030305@denx.de>
Message-ID: <57468324.2040901@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 02/05/16 04:46, Marek Vasut wrote:
> On 05/01/2016 08:57 PM, Tom Rini wrote:
>> On Sun, May 01, 2016 at 12:36:12AM +0200, Marek Vasut wrote:
>>
>>> The exynos5 platforms use DM in U-Boot and do not use DM in SPL. The serial
>>> driver, serial_s5p.c, is DM-only. This is OK for U-Boot, but in SPL, this
>>> will fail with the following compile error:
>>>
>>> drivers/built-in.o: In function `get_current':
>>> ...u-boot/drivers/serial/serial.c:387: undefined reference to `default_serial_console'
>>>
>>> This warning happens because common/console.c is compiled into U-Boot SPL
>>> if CONFIG_SPL_SERIAL_SUPPORT . The common/console.c invokes serial_*()
>>> functions and since exynos5 does not use DM in SPL, these functions come
>>> from drivers/serial/serial.c . The serial_*() locate default serial port
>>> by calling default_serial_console(), but because the serial_s5p.c is DM-only,
>>> it does no longer define default_serial_console(). Thus the error.
>>
>> This is OK short term
> 
> Yes, indeed.
> 
>> can you see if turning on DM in SPL is easy for
>> these platforms instead?  Thanks!
>>
> I hope Simon can take a look into that ;-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.