public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: exynos: Fix build error if SERIAL is disabled in SPL
Date: Thu, 26 May 2016 14:01:24 +0900	[thread overview]
Message-ID: <57468324.9010803@samsung.com> (raw)
In-Reply-To: <CAPnjgZ2E08uHOAXL+F9bPc4_=jkSJ1qfLSm0SwwGHivr-i=hig@mail.gmail.com>

On 02/05/16 03:55, Simon Glass wrote:
> +Minkyu
> 
> On 30 April 2016 at 16:36, Marek Vasut <marex@denx.de> wrote:
>> If CONFIG_SPL_SERIAL_SUPPORT is not defined in include/configs/exynos5-common.h
>> the following error is produced during the build of the SPL:
>>
>> arch/arm/mach-exynos/built-in.o: In function `do_lowlevel_init':
>> ...u-boot/arch/arm/mach-exynos/lowlevel_init.c:221: undefined reference to `debug_uart_init'
>>
>> Add additional condition to check if SPL build is in progress and
>> in that case check if CONFIG_SPL_SERIAL_SUPPORT is also set before
>> enabling the debug UART.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Tom Rini <trini@konsulko.com>
>> ---
>>  arch/arm/mach-exynos/lowlevel_init.c | 3 +++
>>  1 file changed, 3 insertions(+)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

      reply	other threads:[~2016-05-26  5:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-30 22:36 [U-Boot] [PATCH 1/2] ARM: exynos: Fix build error if SERIAL is disabled in SPL Marek Vasut
2016-04-30 22:36 ` [U-Boot] [PATCH 2/2] ARM: exynos: Disable serial support " Marek Vasut
2016-05-01 18:55   ` Simon Glass
2016-05-01 18:57   ` Tom Rini
2016-05-01 19:46     ` Marek Vasut
2016-05-26  5:01       ` Minkyu Kang
2016-05-01 18:55 ` [U-Boot] [PATCH 1/2] ARM: exynos: Fix build error if SERIAL is disabled " Simon Glass
2016-05-26  5:01   ` Minkyu Kang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57468324.9010803@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox