* [U-Boot] [PATCH] mips: Add SPL header
@ 2016-05-26 18:43 Marek Vasut
2016-05-27 12:09 ` Daniel Schwierzeck
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2016-05-26 18:43 UTC (permalink / raw)
To: u-boot
From: Paul Burton <paul.burton@imgtec.com>
Add header with SPL boot mode and type definitions.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Cc: Paul Burton <paul.burton@imgtec.com>
---
arch/mips/include/asm/spl.h | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
create mode 100644 arch/mips/include/asm/spl.h
diff --git a/arch/mips/include/asm/spl.h b/arch/mips/include/asm/spl.h
new file mode 100644
index 0000000..01baab6
--- /dev/null
+++ b/arch/mips/include/asm/spl.h
@@ -0,0 +1,35 @@
+/*
+ * (C) Copyright 2012
+ * Texas Instruments, <www.ti.com>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+#ifndef _ASM_SPL_H_
+#define _ASM_SPL_H_
+
+enum {
+ BOOT_DEVICE_RAM,
+ BOOT_DEVICE_MMC1,
+ BOOT_DEVICE_MMC2,
+ BOOT_DEVICE_MMC2_2,
+ BOOT_DEVICE_NAND,
+ BOOT_DEVICE_ONENAND,
+ BOOT_DEVICE_NOR,
+ BOOT_DEVICE_UART,
+ BOOT_DEVICE_SPI,
+ BOOT_DEVICE_USB,
+ BOOT_DEVICE_SATA,
+ BOOT_DEVICE_I2C,
+ BOOT_DEVICE_BOARD,
+ BOOT_DEVICE_NONE
+};
+
+/* Linker symbols. */
+extern char __bss_start[];
+extern ulong __bss_end;
+
+#ifndef CONFIG_DM
+extern gd_t gdata;
+#endif
+
+#endif
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] mips: Add SPL header
2016-05-26 18:43 [U-Boot] [PATCH] mips: Add SPL header Marek Vasut
@ 2016-05-27 12:09 ` Daniel Schwierzeck
2016-05-27 12:42 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Schwierzeck @ 2016-05-27 12:09 UTC (permalink / raw)
To: u-boot
Am 26.05.2016 um 20:43 schrieb Marek Vasut:
> From: Paul Burton <paul.burton@imgtec.com>
>
> Add header with SPL boot mode and type definitions.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Paul Burton <paul.burton@imgtec.com>
> ---
> arch/mips/include/asm/spl.h | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 arch/mips/include/asm/spl.h
>
> diff --git a/arch/mips/include/asm/spl.h b/arch/mips/include/asm/spl.h
> new file mode 100644
> index 0000000..01baab6
> --- /dev/null
> +++ b/arch/mips/include/asm/spl.h
> @@ -0,0 +1,35 @@
> +/*
> + * (C) Copyright 2012
> + * Texas Instruments, <www.ti.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +#ifndef _ASM_SPL_H_
> +#define _ASM_SPL_H_
> +
> +enum {
> + BOOT_DEVICE_RAM,
> + BOOT_DEVICE_MMC1,
> + BOOT_DEVICE_MMC2,
> + BOOT_DEVICE_MMC2_2,
> + BOOT_DEVICE_NAND,
> + BOOT_DEVICE_ONENAND,
> + BOOT_DEVICE_NOR,
> + BOOT_DEVICE_UART,
> + BOOT_DEVICE_SPI,
> + BOOT_DEVICE_USB,
> + BOOT_DEVICE_SATA,
> + BOOT_DEVICE_I2C,
> + BOOT_DEVICE_BOARD,
> + BOOT_DEVICE_NONE
> +};
> +
> +/* Linker symbols. */
> +extern char __bss_start[];
> +extern ulong __bss_end;
why not "extern char __bss_end[]" like on ARM?
> +
> +#ifndef CONFIG_DM
> +extern gd_t gdata;
> +#endif
> +
> +#endif
>
--
- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160527/ef38f233/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] mips: Add SPL header
2016-05-27 12:09 ` Daniel Schwierzeck
@ 2016-05-27 12:42 ` Marek Vasut
2016-05-27 13:21 ` Daniel Schwierzeck
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2016-05-27 12:42 UTC (permalink / raw)
To: u-boot
On 05/27/2016 02:09 PM, Daniel Schwierzeck wrote:
>
>
> Am 26.05.2016 um 20:43 schrieb Marek Vasut:
>> From: Paul Burton <paul.burton@imgtec.com>
>>
>> Add header with SPL boot mode and type definitions.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>> Cc: Paul Burton <paul.burton@imgtec.com>
>> ---
>> arch/mips/include/asm/spl.h | 35 +++++++++++++++++++++++++++++++++++
>> 1 file changed, 35 insertions(+)
>> create mode 100644 arch/mips/include/asm/spl.h
>>
>> diff --git a/arch/mips/include/asm/spl.h b/arch/mips/include/asm/spl.h
>> new file mode 100644
>> index 0000000..01baab6
>> --- /dev/null
>> +++ b/arch/mips/include/asm/spl.h
>> @@ -0,0 +1,35 @@
>> +/*
>> + * (C) Copyright 2012
>> + * Texas Instruments, <www.ti.com>
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +#ifndef _ASM_SPL_H_
>> +#define _ASM_SPL_H_
>> +
>> +enum {
>> + BOOT_DEVICE_RAM,
>> + BOOT_DEVICE_MMC1,
>> + BOOT_DEVICE_MMC2,
>> + BOOT_DEVICE_MMC2_2,
>> + BOOT_DEVICE_NAND,
>> + BOOT_DEVICE_ONENAND,
>> + BOOT_DEVICE_NOR,
>> + BOOT_DEVICE_UART,
>> + BOOT_DEVICE_SPI,
>> + BOOT_DEVICE_USB,
>> + BOOT_DEVICE_SATA,
>> + BOOT_DEVICE_I2C,
>> + BOOT_DEVICE_BOARD,
>> + BOOT_DEVICE_NONE
>> +};
>> +
>> +/* Linker symbols. */
>> +extern char __bss_start[];
>> +extern ulong __bss_end;
>
> why not "extern char __bss_end[]" like on ARM?
Because mips defines this symbol as ulong __bss_end all over the place.
I find it weird too and I suspect it's something to synchronize with
other platforms.
>> +
>> +#ifndef CONFIG_DM
>> +extern gd_t gdata;
>> +#endif
>> +
>> +#endif
>>
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] mips: Add SPL header
2016-05-27 12:42 ` Marek Vasut
@ 2016-05-27 13:21 ` Daniel Schwierzeck
2016-05-27 13:23 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Schwierzeck @ 2016-05-27 13:21 UTC (permalink / raw)
To: u-boot
Am 27.05.2016 um 14:42 schrieb Marek Vasut:
> On 05/27/2016 02:09 PM, Daniel Schwierzeck wrote:
>>
>>
>> Am 26.05.2016 um 20:43 schrieb Marek Vasut:
>>> From: Paul Burton <paul.burton@imgtec.com>
>>>
>>> Add header with SPL boot mode and type definitions.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>>> Cc: Paul Burton <paul.burton@imgtec.com>
>>> ---
>>> arch/mips/include/asm/spl.h | 35 +++++++++++++++++++++++++++++++++++
>>> 1 file changed, 35 insertions(+)
>>> create mode 100644 arch/mips/include/asm/spl.h
>>>
>>> diff --git a/arch/mips/include/asm/spl.h b/arch/mips/include/asm/spl.h
>>> new file mode 100644
>>> index 0000000..01baab6
>>> --- /dev/null
>>> +++ b/arch/mips/include/asm/spl.h
>>> @@ -0,0 +1,35 @@
>>> +/*
>>> + * (C) Copyright 2012
>>> + * Texas Instruments, <www.ti.com>
>>> + *
>>> + * SPDX-License-Identifier: GPL-2.0+
>>> + */
>>> +#ifndef _ASM_SPL_H_
>>> +#define _ASM_SPL_H_
>>> +
>>> +enum {
>>> + BOOT_DEVICE_RAM,
>>> + BOOT_DEVICE_MMC1,
>>> + BOOT_DEVICE_MMC2,
>>> + BOOT_DEVICE_MMC2_2,
>>> + BOOT_DEVICE_NAND,
>>> + BOOT_DEVICE_ONENAND,
>>> + BOOT_DEVICE_NOR,
>>> + BOOT_DEVICE_UART,
>>> + BOOT_DEVICE_SPI,
>>> + BOOT_DEVICE_USB,
>>> + BOOT_DEVICE_SATA,
>>> + BOOT_DEVICE_I2C,
>>> + BOOT_DEVICE_BOARD,
>>> + BOOT_DEVICE_NONE
>>> +};
>>> +
>>> +/* Linker symbols. */
>>> +extern char __bss_start[];
>>> +extern ulong __bss_end;
>>
>> why not "extern char __bss_end[]" like on ARM?
>
> Because mips defines this symbol as ulong __bss_end all over the place.
> I find it weird too and I suspect it's something to synchronize with
> other platforms.
>
hm, it's defined in include/asm-generic/sections.h. All archs but ARM
are using ulong __bss_end.
But why isn't there a include/asm-generic/spl.h? The enum should be
platform-independent and the linker symbols could be pulled from
include/asm-generic/sections.h.
--
- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160527/848c6e77/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] mips: Add SPL header
2016-05-27 13:21 ` Daniel Schwierzeck
@ 2016-05-27 13:23 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2016-05-27 13:23 UTC (permalink / raw)
To: u-boot
On 05/27/2016 03:21 PM, Daniel Schwierzeck wrote:
>
>
> Am 27.05.2016 um 14:42 schrieb Marek Vasut:
>> On 05/27/2016 02:09 PM, Daniel Schwierzeck wrote:
>>>
>>>
>>> Am 26.05.2016 um 20:43 schrieb Marek Vasut:
>>>> From: Paul Burton <paul.burton@imgtec.com>
>>>>
>>>> Add header with SPL boot mode and type definitions.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
>>>> Cc: Paul Burton <paul.burton@imgtec.com>
>>>> ---
>>>> arch/mips/include/asm/spl.h | 35 +++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 35 insertions(+)
>>>> create mode 100644 arch/mips/include/asm/spl.h
>>>>
>>>> diff --git a/arch/mips/include/asm/spl.h b/arch/mips/include/asm/spl.h
>>>> new file mode 100644
>>>> index 0000000..01baab6
>>>> --- /dev/null
>>>> +++ b/arch/mips/include/asm/spl.h
>>>> @@ -0,0 +1,35 @@
>>>> +/*
>>>> + * (C) Copyright 2012
>>>> + * Texas Instruments, <www.ti.com>
>>>> + *
>>>> + * SPDX-License-Identifier: GPL-2.0+
>>>> + */
>>>> +#ifndef _ASM_SPL_H_
>>>> +#define _ASM_SPL_H_
>>>> +
>>>> +enum {
>>>> + BOOT_DEVICE_RAM,
>>>> + BOOT_DEVICE_MMC1,
>>>> + BOOT_DEVICE_MMC2,
>>>> + BOOT_DEVICE_MMC2_2,
>>>> + BOOT_DEVICE_NAND,
>>>> + BOOT_DEVICE_ONENAND,
>>>> + BOOT_DEVICE_NOR,
>>>> + BOOT_DEVICE_UART,
>>>> + BOOT_DEVICE_SPI,
>>>> + BOOT_DEVICE_USB,
>>>> + BOOT_DEVICE_SATA,
>>>> + BOOT_DEVICE_I2C,
>>>> + BOOT_DEVICE_BOARD,
>>>> + BOOT_DEVICE_NONE
>>>> +};
>>>> +
>>>> +/* Linker symbols. */
>>>> +extern char __bss_start[];
>>>> +extern ulong __bss_end;
>>>
>>> why not "extern char __bss_end[]" like on ARM?
>>
>> Because mips defines this symbol as ulong __bss_end all over the place.
>> I find it weird too and I suspect it's something to synchronize with
>> other platforms.
>>
>
> hm, it's defined in include/asm-generic/sections.h. All archs but ARM
> are using ulong __bss_end.
>
> But why isn't there a include/asm-generic/spl.h? The enum should be
> platform-independent and the linker symbols could be pulled from
> include/asm-generic/sections.h.
>
Yes, indeed, you have a point. I'll put unifying spl.h on the list just
after libgcc issues.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-27 13:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-26 18:43 [U-Boot] [PATCH] mips: Add SPL header Marek Vasut
2016-05-27 12:09 ` Daniel Schwierzeck
2016-05-27 12:42 ` Marek Vasut
2016-05-27 13:21 ` Daniel Schwierzeck
2016-05-27 13:23 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox