public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: remove dead code from asm/u-boot-mips.h
Date: Fri, 27 May 2016 15:42:57 +0200	[thread overview]
Message-ID: <57484EE1.7020608@denx.de> (raw)
In-Reply-To: <1464355894-4118-1-git-send-email-daniel.schwierzeck@gmail.com>

On 05/27/2016 03:31 PM, Daniel Schwierzeck wrote:
> Those wrappers for linker symbols were once used in the MIPS
> specific board.c implementation. Since the migration to generic
> board.c, those wrappers are dead code and can be removed.
> 
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>

Why don't you nuke the whole file ?

> ---
> 
>  arch/mips/include/asm/u-boot-mips.h | 21 +++------------------
>  1 file changed, 3 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/mips/include/asm/u-boot-mips.h b/arch/mips/include/asm/u-boot-mips.h
> index a5b2fc0..1f527bb 100644
> --- a/arch/mips/include/asm/u-boot-mips.h
> +++ b/arch/mips/include/asm/u-boot-mips.h
> @@ -1,23 +1,8 @@
>  /*
>   * SPDX-License-Identifier:	GPL-2.0+
> - *
> - * Copyright (C) 2003 Wolfgang Denk, DENX Software Engineering, wd at denx.de
>   */
>  
> -static inline unsigned long bss_start(void)
> -{
> -	extern char __bss_start[];
> -	return (unsigned long) &__bss_start;
> -}
> +#ifndef _U_BOOT_MIPS_H_
> +#define _U_BOOT_MIPS_H_
>  
> -static inline unsigned long bss_end(void)
> -{
> -	extern ulong __bss_end;
> -	return (unsigned long) &__bss_end;
> -}
> -
> -static inline unsigned long image_copy_end(void)
> -{
> -	extern char __image_copy_end[];
> -	return (unsigned long) &__image_copy_end;
> -}
> +#endif /* _U_BOOT_MIPS_H_ */
> 


-- 
Best regards,
Marek Vasut

      reply	other threads:[~2016-05-27 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 13:31 [U-Boot] [PATCH] MIPS: remove dead code from asm/u-boot-mips.h Daniel Schwierzeck
2016-05-27 13:42 ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57484EE1.7020608@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox