[U-Boot] [PATCH] MIPS: remove dead code from asm/u-boot-mips.h

[U-Boot] [PATCH] MIPS: remove dead code from asm/u-boot-mips.h

[Daniel Schwierzeck]

Those wrappers for linker symbols were once used in the MIPS
specific board.c implementation. Since the migration to generic
board.c, those wrappers are dead code and can be removed.

Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>

---

 arch/mips/include/asm/u-boot-mips.h | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/arch/mips/include/asm/u-boot-mips.h b/arch/mips/include/asm/u-boot-mips.h
index a5b2fc0..1f527bb 100644
--- a/arch/mips/include/asm/u-boot-mips.h
+++ b/arch/mips/include/asm/u-boot-mips.h
@@ -1,23 +1,8 @@
 /*
  * SPDX-License-Identifier:	GPL-2.0+
- *
- * Copyright (C) 2003 Wolfgang Denk, DENX Software Engineering, wd at denx.de
  */
 
-static inline unsigned long bss_start(void)
-{
-	extern char __bss_start[];
-	return (unsigned long) &__bss_start;
-}
+#ifndef _U_BOOT_MIPS_H_
+#define _U_BOOT_MIPS_H_
 
-static inline unsigned long bss_end(void)
-{
-	extern ulong __bss_end;
-	return (unsigned long) &__bss_end;
-}
-
-static inline unsigned long image_copy_end(void)
-{
-	extern char __image_copy_end[];
-	return (unsigned long) &__image_copy_end;
-}
+#endif /* _U_BOOT_MIPS_H_ */
-- 
2.7.4

[U-Boot] [PATCH] MIPS: remove dead code from asm/u-boot-mips.h

[Marek Vasut]

On 05/27/2016 03:31 PM, Daniel Schwierzeck wrote:
> Those wrappers for linker symbols were once used in the MIPS
> specific board.c implementation. Since the migration to generic
> board.c, those wrappers are dead code and can be removed.
> 
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>

Why don't you nuke the whole file ?

> ---
> 
>  arch/mips/include/asm/u-boot-mips.h | 21 +++------------------
>  1 file changed, 3 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/mips/include/asm/u-boot-mips.h b/arch/mips/include/asm/u-boot-mips.h
> index a5b2fc0..1f527bb 100644
> --- a/arch/mips/include/asm/u-boot-mips.h
> +++ b/arch/mips/include/asm/u-boot-mips.h
> @@ -1,23 +1,8 @@
>  /*
>   * SPDX-License-Identifier:	GPL-2.0+
> - *
> - * Copyright (C) 2003 Wolfgang Denk, DENX Software Engineering, wd at denx.de
>   */
>  
> -static inline unsigned long bss_start(void)
> -{
> -	extern char __bss_start[];
> -	return (unsigned long) &__bss_start;
> -}
> +#ifndef _U_BOOT_MIPS_H_
> +#define _U_BOOT_MIPS_H_
>  
> -static inline unsigned long bss_end(void)
> -{
> -	extern ulong __bss_end;
> -	return (unsigned long) &__bss_end;
> -}
> -
> -static inline unsigned long image_copy_end(void)
> -{
> -	extern char __image_copy_end[];
> -	return (unsigned long) &__image_copy_end;
> -}
> +#endif /* _U_BOOT_MIPS_H_ */
> 


-- 
Best regards,
Marek Vasut