From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 31 May 2016 17:35:41 +0200 Subject: [U-Boot] [PATCH v2 1/8] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3 In-Reply-To: References: Message-ID: <574DAF4D.9000700@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Andrew, On 30/05/2016 13:37, Andrew Shadura wrote: > detect_baseboard() function doesn't depend on CONFIG_VIDEO_IPUV3. > Make sure it's available when CONFIG_VIDEO_IPUV3 is off. > > Signed-off-by: Andrew Shadura > --- > board/ge/bx50v3/bx50v3.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c > index ff8f4d7..e167cd5 100644 > --- a/board/ge/bx50v3/bx50v3.c > +++ b/board/ge/bx50v3/bx50v3.c > @@ -321,6 +321,15 @@ int board_phy_config(struct phy_device *phydev) > return 0; > } > > +static int detect_baseboard(struct display_info_t const *dev) > +{ > + if (IS_ENABLED(CONFIG_TARGET_GE_B450V3) || > + IS_ENABLED(CONFIG_TARGET_GE_B650V3)) > + return 1; > + > + return 0; > +} > + > #if defined(CONFIG_VIDEO_IPUV3) > static iomux_v3_cfg_t const backlight_pads[] = { > /* Power for LVDS Display */ > @@ -345,15 +354,6 @@ int board_cfb_skip(void) > return 0; > } > > -static int detect_baseboard(struct display_info_t const *dev) > -{ > - if (IS_ENABLED(CONFIG_TARGET_GE_B450V3) || > - IS_ENABLED(CONFIG_TARGET_GE_B650V3)) > - return 1; > - > - return 0; > -} > - > struct display_info_t const displays[] = {{ > .bus = -1, > .addr = -1, > But this generates a warning: w+board/ge/bx50v3/bx50v3.c:324:12: warning: 'detect_baseboard' defined but not used [-Wunused-function] Why do you export it if you do not need it ? It is used only in the hdmi detection, that means just if IPU is set. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================