public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig
@ 2016-05-31 22:00 Marek Vasut
  2016-05-31 22:55 ` Tom Rini
  2016-06-03 14:00 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 5+ messages in thread
From: Marek Vasut @ 2016-05-31 22:00 UTC (permalink / raw)
  To: u-boot

This fixes the last remaining libgcc warning, where the symbol was
defined twice.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
 configs/tplink_wdr4300_defconfig | 1 +
 include/configs/tplink_wdr4300.h | 2 --
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/configs/tplink_wdr4300_defconfig b/configs/tplink_wdr4300_defconfig
index b1af2f6..3eec4c2 100644
--- a/configs/tplink_wdr4300_defconfig
+++ b/configs/tplink_wdr4300_defconfig
@@ -1,6 +1,7 @@
 CONFIG_MIPS=y
 CONFIG_ARCH_ATH79=y
 CONFIG_BOARD_TPLINK_WDR4300=y
+CONFIG_USE_PRIVATE_LIBGCC=y
 CONFIG_SYS_MALLOC_F_LEN=0x2000
 CONFIG_SYS_NS16550=y
 CONFIG_DM_SERIAL=y
diff --git a/include/configs/tplink_wdr4300.h b/include/configs/tplink_wdr4300.h
index 6273711..abe1da2 100644
--- a/include/configs/tplink_wdr4300.h
+++ b/include/configs/tplink_wdr4300.h
@@ -78,8 +78,6 @@
 #define CONFIG_SYS_MEMTEST_END		0x83f00000
 #define CONFIG_CMD_MEMTEST
 
-#define CONFIG_USE_PRIVATE_LIBGCC
-
 #define CONFIG_CMD_MII
 #define CONFIG_PHY_GIGE
 
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig
  2016-05-31 22:00 [U-Boot] [PATCH] mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig Marek Vasut
@ 2016-05-31 22:55 ` Tom Rini
  2016-06-01 12:34   ` Daniel Schwierzeck
  2016-06-03 14:00 ` [U-Boot] " Tom Rini
  1 sibling, 1 reply; 5+ messages in thread
From: Tom Rini @ 2016-05-31 22:55 UTC (permalink / raw)
  To: u-boot

On Wed, Jun 01, 2016 at 12:00:02AM +0200, Marek Vasut wrote:

> This fixes the last remaining libgcc warning, where the symbol was
> defined twice.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160531/55e89143/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig
  2016-05-31 22:55 ` Tom Rini
@ 2016-06-01 12:34   ` Daniel Schwierzeck
  2016-06-01 14:58     ` Tom Rini
  0 siblings, 1 reply; 5+ messages in thread
From: Daniel Schwierzeck @ 2016-06-01 12:34 UTC (permalink / raw)
  To: u-boot

Hi Tom,

Am 01.06.2016 um 00:55 schrieb Tom Rini:
> On Wed, Jun 01, 2016 at 12:00:02AM +0200, Marek Vasut wrote:
> 
>> This fixes the last remaining libgcc warning, where the symbol was
>> defined twice.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Tom Rini <trini@konsulko.com>
> 
> Reviewed-by: Tom Rini <trini@konsulko.com>
> 

could you apply this patch or shall I create a PR?

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160601/23ccc9eb/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig
  2016-06-01 12:34   ` Daniel Schwierzeck
@ 2016-06-01 14:58     ` Tom Rini
  0 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2016-06-01 14:58 UTC (permalink / raw)
  To: u-boot

On Wed, Jun 01, 2016 at 02:34:41PM +0200, Daniel Schwierzeck wrote:
> Hi Tom,
> 
> Am 01.06.2016 um 00:55 schrieb Tom Rini:
> > On Wed, Jun 01, 2016 at 12:00:02AM +0200, Marek Vasut wrote:
> > 
> >> This fixes the last remaining libgcc warning, where the symbol was
> >> defined twice.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Simon Glass <sjg@chromium.org>
> >> Cc: Tom Rini <trini@konsulko.com>
> > 
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> 
> could you apply this patch or shall I create a PR?

I'll pick it up prior to applying the libgcc series, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160601/714a871d/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig
  2016-05-31 22:00 [U-Boot] [PATCH] mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig Marek Vasut
  2016-05-31 22:55 ` Tom Rini
@ 2016-06-03 14:00 ` Tom Rini
  1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2016-06-03 14:00 UTC (permalink / raw)
  To: u-boot

On Wed, Jun 01, 2016 at 12:00:02AM +0200, Marek Vasut wrote:

> This fixes the last remaining libgcc warning, where the symbol was
> defined twice.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160603/2586cbe9/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-06-03 14:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-31 22:00 [U-Boot] [PATCH] mips: wdr4300: Move the CONFIG_USE_PRIVATE_LIBGCC to Kconfig Marek Vasut
2016-05-31 22:55 ` Tom Rini
2016-06-01 12:34   ` Daniel Schwierzeck
2016-06-01 14:58     ` Tom Rini
2016-06-03 14:00 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox