Re: [RFC PATCH 2/2] board: ti: am65x: Move to using Extension framework

[Roger Quadros <rogerq@kernel.org>]

Hi Simon,

On 10/07/2023 22:45, Simon Glass wrote:
> Hi Roger,
> 
> On Mon, 10 Jul 2023 at 08:51, Roger Quadros <rogerq@kernel.org> wrote:
>>
>> Support the Expansion cards via Extension framework.
>> This should make 'expansion' command work to scan
>> for expansion cards and apply DT overlays.
>>
>> Card detection code is moved to a library so
>> other boards can benefit from it.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>>  board/ti/am65x/evm.c               | 264 ++++++++---------------------
>>  board/ti/common/Kconfig            |   8 +
>>  board/ti/common/Makefile           |   1 +
>>  board/ti/common/ti_card_detect.c   | 155 +++++++++++++++++
>>  board/ti/common/ti_card_detect.h   |  43 +++++
>>  configs/am65x_evm_a53_defconfig    |   2 +
>>  configs/am65x_hs_evm_a53_defconfig |   2 +
>>  7 files changed, 280 insertions(+), 195 deletions(-)
>>  create mode 100644 board/ti/common/ti_card_detect.c
>>  create mode 100644 board/ti/common/ti_card_detect.h
> 
> Before this goes too far I think this should move to using a linker
> list to declare the driver (or a driver-model driver if you prefer,
> but that might be overkill).

ti_card_detect.c This is not a device driver but just a helper library
which is ultimately going to be used directly by the board files.

e.g.
see board/ti/am65x/evm.c

> 
> What do people think?
> 
> Regards,
> Simon

-- 
cheers,
-roger