From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC122C0015E for ; Tue, 11 Jul 2023 12:29:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A8B9886834; Tue, 11 Jul 2023 14:29:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="pGSToz2Q"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 25C8086833; Tue, 11 Jul 2023 14:29:25 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E9EFE86833 for ; Tue, 11 Jul 2023 14:29:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C4B50614E5; Tue, 11 Jul 2023 12:29:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10AD5C433CB; Tue, 11 Jul 2023 12:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689078559; bh=F2U50u+ZQ7YfRv6+C9F3HN7Y6mpsF4h6xP+chg3lKE4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pGSToz2QI+im5SIOFXpLBBh566sFyhw8Jk5RcdbSbckpnZtjGxuWKAahuMrWdMCJ5 iu/SHUCENisaGubvKZeETYUhS9A3tAobVHYR4VRPkNMYAKzcmoxEtVZ439f4uYQoP9 IWQRtqrngCerxXAUJbyB2hHLT/Za17gF+gSPU/VA4SRjAOjOaItDBDsIbPqkdPmiJ7 /JEv8OshCM1UGgf5xlZ1pRSbe6fffvdInNmK+GWJQq5TJoPUUBKT9hcb+k75uk0q27 h7uKTUDKjyM3DTTRCLVnGQoBu40NLqD5cN8NmSRmbXzyJlM5KoK9o/FtgOfnu7C9BZ WFpjF4SKLCB+w== Message-ID: <574c8eb0-4c19-72ef-5920-e506e4be6203@kernel.org> Date: Tue, 11 Jul 2023 15:29:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [RFC PATCH 2/2] board: ti: am65x: Move to using Extension framework Content-Language: en-US To: Simon Glass Cc: nm@ti.com, vigneshr@ti.com, trini@konsulko.com, srk@ti.com, robertcnelson@gmail.com, u-boot@lists.denx.de References: <20230710145026.128481-1-rogerq@kernel.org> <20230710145026.128481-3-rogerq@kernel.org> From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 10/07/2023 22:45, Simon Glass wrote: > Hi Roger, > > On Mon, 10 Jul 2023 at 08:51, Roger Quadros wrote: >> >> Support the Expansion cards via Extension framework. >> This should make 'expansion' command work to scan >> for expansion cards and apply DT overlays. >> >> Card detection code is moved to a library so >> other boards can benefit from it. >> >> Signed-off-by: Roger Quadros >> --- >> board/ti/am65x/evm.c | 264 ++++++++--------------------- >> board/ti/common/Kconfig | 8 + >> board/ti/common/Makefile | 1 + >> board/ti/common/ti_card_detect.c | 155 +++++++++++++++++ >> board/ti/common/ti_card_detect.h | 43 +++++ >> configs/am65x_evm_a53_defconfig | 2 + >> configs/am65x_hs_evm_a53_defconfig | 2 + >> 7 files changed, 280 insertions(+), 195 deletions(-) >> create mode 100644 board/ti/common/ti_card_detect.c >> create mode 100644 board/ti/common/ti_card_detect.h > > Before this goes too far I think this should move to using a linker > list to declare the driver (or a driver-model driver if you prefer, > but that might be overkill). ti_card_detect.c This is not a device driver but just a helper library which is ultimately going to be used directly by the board files. e.g. see board/ti/am65x/evm.c > > What do people think? > > Regards, > Simon -- cheers, -roger