[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

[Ravi Babu]

Avoid use of hard coded mmcdev value so finduuid works
based on current mmcdev selected.

Signed-off-by: Ravi Babu <ravibabu@ti.com>
---
 include/configs/ti_armv7_common.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
index 7db0881..bbff06b 100644
--- a/include/configs/ti_armv7_common.h
+++ b/include/configs/ti_armv7_common.h
@@ -59,7 +59,7 @@
 #define DEFAULT_MMC_TI_ARGS \
 	"mmcdev=0\0" \
 	"mmcrootfstype=ext4 rootwait\0" \
-	"finduuid=part uuid mmc 0:2 uuid\0" \
+	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
 	"args_mmc=run finduuid;setenv bootargs console=${console} " \
 		"${optargs} " \
 		"root=PARTUUID=${uuid} rw " \
-- 
1.7.9.5

[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

[Lokesh Vutla]

On 6/2/2016 6:14 PM, Ravi Babu wrote:
> Avoid use of hard coded mmcdev value so finduuid works
> based on current mmcdev selected.

Acked-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

>
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> ---
>   include/configs/ti_armv7_common.h |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
> index 7db0881..bbff06b 100644
> --- a/include/configs/ti_armv7_common.h
> +++ b/include/configs/ti_armv7_common.h
> @@ -59,7 +59,7 @@
>   #define DEFAULT_MMC_TI_ARGS \
>   	"mmcdev=0\0" \
>   	"mmcrootfstype=ext4 rootwait\0" \
> -	"finduuid=part uuid mmc 0:2 uuid\0" \
> +	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
>   	"args_mmc=run finduuid;setenv bootargs console=${console} " \
>   		"${optargs} " \
>   		"root=PARTUUID=${uuid} rw " \
>

[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

[Tom Rini]

On Thu, Jun 02, 2016 at 06:14:27PM +0530, Ravi Babu wrote:
> Avoid use of hard coded mmcdev value so finduuid works
> based on current mmcdev selected.
> 
> Signed-off-by: Ravi Babu <ravibabu@ti.com>
> ---
>  include/configs/ti_armv7_common.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
> index 7db0881..bbff06b 100644
> --- a/include/configs/ti_armv7_common.h
> +++ b/include/configs/ti_armv7_common.h
> @@ -59,7 +59,7 @@
>  #define DEFAULT_MMC_TI_ARGS \
>  	"mmcdev=0\0" \
>  	"mmcrootfstype=ext4 rootwait\0" \
> -	"finduuid=part uuid mmc 0:2 uuid\0" \
> +	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
>  	"args_mmc=run finduuid;setenv bootargs console=${console} " \
>  		"${optargs} " \
>  		"root=PARTUUID=${uuid} rw " \

Good, but incomplete find.  am33xx doesn't, but other TI families do,
"common"-out the bootpart variable and this is what should be used here,
after making sure everyone that uses this has a bootpart set.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160602/85d7c49b/attachment.sig>

[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

[B, Ravi]

Hi Tom

>> Avoid use of hard coded mmcdev value so finduuid works based on 
>> current mmcdev selected.
>> 
>> Signed-off-by: Ravi Babu <ravibabu@ti.com>
>> ---
>>  include/configs/ti_armv7_common.h |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/configs/ti_armv7_common.h 
>> b/include/configs/ti_armv7_common.h
>> index 7db0881..bbff06b 100644
>> --- a/include/configs/ti_armv7_common.h
>> +++ b/include/configs/ti_armv7_common.h
>> @@ -59,7 +59,7 @@
>>  #define DEFAULT_MMC_TI_ARGS \
>>  	"mmcdev=0\0" \
>>  	"mmcrootfstype=ext4 rootwait\0" \
>> -	"finduuid=part uuid mmc 0:2 uuid\0" \
>> +	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
>>  	"args_mmc=run finduuid;setenv bootargs console=${console} " \
>>  		"${optargs} " \
>>  		"root=PARTUUID=${uuid} rw " \

>Good, but incomplete find.  am33xx doesn't, but other TI families do, "common"-out the bootpart variable and this is what should be used here, after making sure everyone that uses this has a bootpart set.

If I understand you correctly, are you saying to use *bootpart* as common variable and define "bootpart=${mmcdev}:2"
But you cannot define "bootpart=${mmcdev}:2" like this and use ${bootpart} in finduuid.
"finduuid=part uuid mmc ${bootpart} uuid\0" - this will _NOT_ work.

In order to make finduuid work,  bootpart must be hard coded with mmcdev:partition as "bootpart=0:2" or "bootpart=1:2".

Please correct me if I understood your idea correctly.

Regards
Ravi 

[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

[B, Ravi]

Hi

>>>  #define DEFAULT_MMC_TI_ARGS \
>>>  	"mmcdev=0\0" \
>>>  	"mmcrootfstype=ext4 rootwait\0" \
>>> -	"finduuid=part uuid mmc 0:2 uuid\0" \
>>> +	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
>>>  	"args_mmc=run finduuid;setenv bootargs console=${console} " \
>>>  		"${optargs} " \
>>>  		"root=PARTUUID=${uuid} rw " \

>>Good, but incomplete find.  am33xx doesn't, but other TI families do, "common"-out the bootpart variable and this is what should be used here, after making sure everyone that uses this has a bootpart set.

>If I understand you correctly, are you saying to use *bootpart* as common variable and define "bootpart=${mmcdev}:2"
>But you cannot define "bootpart=${mmcdev}:2" like this and use ${bootpart} in finduuid.
>"finduuid=part uuid mmc ${bootpart} uuid\0" - this will _NOT_ work.

>In order to make finduuid work,  bootpart must be hard coded with mmcdev:partition as "bootpart=0:2" or "bootpart=1:2".

>Please correct me if I understood your idea correctly.

You are right, use of bootpart would be more ideal than use mmcdev. The bootpart will be set based on platform specific boot device:partition.

diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
index 7db0881..bbff06b 100644
--- a/include/configs/ti_armv7_common.h
+++ b/include/configs/ti_armv7_common.h
@@ -59,7 +59,7 @@
 #define DEFAULT_MMC_TI_ARGS \
 	"mmcdev=0\0" \
 	"mmcrootfstype=ext4 rootwait\0" \
-	"finduuid=part uuid mmc 0:2 uuid\0" \
+	"finduuid=part uuid mmc ${bootpart} uuid\0" \
 	"args_mmc=run finduuid;setenv bootargs console=${console} " \
 		"${optargs} " \
 		"root=PARTUUID=${uuid} rw " \

Regards
Ravi 

[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

[Tom Rini]

On Fri, Jun 03, 2016 at 08:05:58AM +0000, B, Ravi wrote:
> Hi
> 
> >>>  #define DEFAULT_MMC_TI_ARGS \
> >>>  	"mmcdev=0\0" \
> >>>  	"mmcrootfstype=ext4 rootwait\0" \
> >>> -	"finduuid=part uuid mmc 0:2 uuid\0" \
> >>> +	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
> >>>  	"args_mmc=run finduuid;setenv bootargs console=${console} " \
> >>>  		"${optargs} " \
> >>>  		"root=PARTUUID=${uuid} rw " \
> 
> >>Good, but incomplete find.  am33xx doesn't, but other TI families do, "common"-out the bootpart variable and this is what should be used here, after making sure everyone that uses this has a bootpart set.
> 
> >If I understand you correctly, are you saying to use *bootpart* as common variable and define "bootpart=${mmcdev}:2"
> >But you cannot define "bootpart=${mmcdev}:2" like this and use ${bootpart} in finduuid.
> >"finduuid=part uuid mmc ${bootpart} uuid\0" - this will _NOT_ work.
> 
> >In order to make finduuid work,  bootpart must be hard coded with mmcdev:partition as "bootpart=0:2" or "bootpart=1:2".
> 
> >Please correct me if I understood your idea correctly.
> 
> You are right, use of bootpart would be more ideal than use mmcdev. The bootpart will be set based on platform specific boot device:partition.
> 
> diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
> index 7db0881..bbff06b 100644
> --- a/include/configs/ti_armv7_common.h
> +++ b/include/configs/ti_armv7_common.h
> @@ -59,7 +59,7 @@
>  #define DEFAULT_MMC_TI_ARGS \
>  	"mmcdev=0\0" \
>  	"mmcrootfstype=ext4 rootwait\0" \
> -	"finduuid=part uuid mmc 0:2 uuid\0" \
> +	"finduuid=part uuid mmc ${bootpart} uuid\0" \
>  	"args_mmc=run finduuid;setenv bootargs console=${console} " \
>  		"${optargs} " \
>  		"root=PARTUUID=${uuid} rw " \

Right.  But not everyone that uses ti_armv7_common.h and
DEFAULT_MMC_TI_ARGS has bootpart set I believe.  Use buildman to build
all of the TI stuff and run 'strings' on u-boot.img to find cases of
'part uuid' but not having bootpart set.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160603/c802ede5/attachment.sig>

[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

[B, Ravi]

Hi Tom

>> diff --git a/include/configs/ti_armv7_common.h 
>> b/include/configs/ti_armv7_common.h
>> index 7db0881..bbff06b 100644
>> --- a/include/configs/ti_armv7_common.h
>> +++ b/include/configs/ti_armv7_common.h
>> @@ -59,7 +59,7 @@
>>  #define DEFAULT_MMC_TI_ARGS \
>>  	"mmcdev=0\0" \
>>  	"mmcrootfstype=ext4 rootwait\0" \
>> -	"finduuid=part uuid mmc 0:2 uuid\0" \
>> +	"finduuid=part uuid mmc ${bootpart} uuid\0" \
>>  	"args_mmc=run finduuid;setenv bootargs console=${console} " \
>>  		"${optargs} " \
>>  		"root=PARTUUID=${uuid} rw " \

>Right.  But not everyone that uses ti_armv7_common.h and DEFAULT_MMC_TI_ARGS has bootpart set I believe.  Use buildman to build all of the TI stuff and run 'strings' on u-boot.img to find cases of 'part uuid' but not having bootpart set.

Yes, you are correct, not all platform uses ti_armv7_common.h, bootpart is defined as part of DEFAULT_MMC_TI_ARGS.
I have run 'strings' on u-boot.img,  I did not find 'part uuid' without ${bootpart}. 

I will post rework of this patch (v1).  Thanks for review.

Regards
Ravi