public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: phy: marvell: Do not reset 88e1310 after autoneg
Date: Fri, 3 Jun 2016 15:38:38 +0200	[thread overview]
Message-ID: <5751885E.6070103@xilinx.com> (raw)
In-Reply-To: <1464959777-30464-1-git-send-email-nathan@nathanrossi.com>

On 3.6.2016 15:16, Nathan Rossi wrote:
> Commit a058052c "net: phy: do not read configuration register on reset",
> changes the behaviour of the phy_reset function such that the state of
> the BMCR register is not preserved during reset.
> 
> Change the config function for the m88e1310 so that it does not do a
> reset after configuring auto-negotiation.
> 
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Stefan Roese <sr@denx.de>
> ---
>  drivers/net/phy/marvell.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
> index d2e68d4..58d287b 100644
> --- a/drivers/net/phy/marvell.c
> +++ b/drivers/net/phy/marvell.c
> @@ -476,10 +476,7 @@ static int m88e1310_config(struct phy_device *phydev)
>  	/* Ensure to return to page 0 */
>  	phy_write(phydev, MDIO_DEVAD_NONE, MIIM_88E1310_PHY_PAGE, 0x0000);
>  
> -	genphy_config_aneg(phydev);
> -	phy_reset(phydev);
> -
> -	return 0;
> +	return genphy_config_aneg(phydev);
>  }
>  
>  static struct phy_driver M88E1011S_driver = {
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

  reply	other threads:[~2016-06-03 13:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 13:16 [U-Boot] [PATCH] net: phy: marvell: Do not reset 88e1310 after autoneg Nathan Rossi
2016-06-03 13:38 ` Michal Simek [this message]
2016-06-03 13:53 ` Joe Hershberger
2016-06-03 14:16 ` Stefan Roese
2016-06-21 22:10 ` [U-Boot] " Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5751885E.6070103@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox