From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: lib: fix push/pop-section directives
Date: Sat, 04 Jun 2016 02:43:06 +0200 [thread overview]
Message-ID: <5752241A.7070202@denx.de> (raw)
In-Reply-To: <20160603191420.GI7419@bill-the-cat>
On 06/03/2016 09:14 PM, Tom Rini wrote:
> On Fri, Jun 03, 2016 at 01:05:11PM -0600, Stephen Warren wrote:
>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> With the existing code, function symbols are defined in .text, and the
>> body is defined in .text.xxx. This causes (at least some version of) the
>> linker not to emit the function body into the final binary, since it's
>> part of a different section to the symbols being referenced. This of
>> course causes a wide variety of failures.
>>
>> This change moves the push/pop-section directives before the function
>> symbols, and after any relate ENDPROC macro invocations, so that symbols
>> and bodies are all in the "pushed" sections, and thus the function bodies
>> are emitted into the binary.
>>
>> This solves (at least) the boot problems currently seen on Tegra systems
>> that use SPL (i.e. all ARMv7 Tegras).
>>
>> Fixes: 13b0a91a6d48 ("arm: lib: Split asm symbols into different .text subsections")
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: Tom Warren <twarren@nvidia.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Applied to u-boot/master, thanks!
>
Thanks!
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2016-06-04 0:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 19:05 [U-Boot] [PATCH] arm: lib: fix push/pop-section directives Stephen Warren
2016-06-03 19:14 ` Tom Rini
2016-06-04 0:43 ` Marek Vasut [this message]
2016-06-04 13:04 ` Tom Rini
2016-06-04 22:47 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5752241A.7070202@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox