From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 05 Jun 2016 00:47:31 +0200 Subject: [U-Boot] [PATCH] arm: lib: fix push/pop-section directives In-Reply-To: <20160604130407.GB11619@bill-the-cat> References: <20160603190511.24909-1-swarren@wwwdotorg.org> <20160603191420.GI7419@bill-the-cat> <5752241A.7070202@denx.de> <20160604130407.GB11619@bill-the-cat> Message-ID: <57535A83.3060102@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/04/2016 03:04 PM, Tom Rini wrote: > On Sat, Jun 04, 2016 at 02:43:06AM +0200, Marek Vasut wrote: >> On 06/03/2016 09:14 PM, Tom Rini wrote: >>> On Fri, Jun 03, 2016 at 01:05:11PM -0600, Stephen Warren wrote: >>> >>>> From: Stephen Warren >>>> >>>> With the existing code, function symbols are defined in .text, and the >>>> body is defined in .text.xxx. This causes (at least some version of) the >>>> linker not to emit the function body into the final binary, since it's >>>> part of a different section to the symbols being referenced. This of >>>> course causes a wide variety of failures. >>>> >>>> This change moves the push/pop-section directives before the function >>>> symbols, and after any relate ENDPROC macro invocations, so that symbols >>>> and bodies are all in the "pushed" sections, and thus the function bodies >>>> are emitted into the binary. >>>> >>>> This solves (at least) the boot problems currently seen on Tegra systems >>>> that use SPL (i.e. all ARMv7 Tegras). >>>> >>>> Fixes: 13b0a91a6d48 ("arm: lib: Split asm symbols into different .text subsections") >>>> Cc: Marek Vasut >>>> Cc: Tom Warren >>>> Cc: Simon Glass >>>> Cc: Masahiro Yamada >>>> Signed-off-by: Stephen Warren >>> >>> Applied to u-boot/master, thanks! >>> >> Thanks! > > So, that said, this breaks VCMA9 and maybe a few other platforms, can > you look a little more Stephen or Marek? Thanks! > Patch is out. -- Best regards, Marek Vasut