From: Lokesh Vutla <lokeshvutla@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: fit: Fix non-matching DT names console output
Date: Sun, 5 Jun 2016 09:03:27 +0530 [thread overview]
Message-ID: <57539D87.80006@ti.com> (raw)
In-Reply-To: <1464980704-26304-1-git-send-email-dannenberg@ti.com>
On 6/4/2016 12:35 AM, Andreas Dannenberg wrote:
> When no DTB can be matched successfully to the board that's being used
> a list of available FIT-embedded DTBs will be output to the console for
> diagnostic purposes. But rather than the contents of the "description"
> FDT property a non-existent property was accessed and as a result "NULL"
> was output instead of the actual name(s) of the DTB(s). Fix this issue
> by using the correct property which is also the exact same property
> that's used earlier during the actual board matching process.
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
>
> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> ---
> common/spl/spl_fit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
> index c9eb020..9874708 100644
> --- a/common/spl/spl_fit.c
> +++ b/common/spl/spl_fit.c
> @@ -77,7 +77,7 @@ static int spl_fit_select_fdt(const void *fdt, int images, int *fdt_offsetp)
> for (node = fdt_first_subnode(fdt, conf);
> node >= 0;
> node = fdt_next_subnode(fdt, node)) {
> - name = fdt_getprop(fdt, node, "name", &len);
> + name = fdt_getprop(fdt, node, "description", &len);
> printf(" %s\n", name);
> }
> #endif
>
next prev parent reply other threads:[~2016-06-05 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 19:05 [U-Boot] [PATCH] spl: fit: Fix non-matching DT names console output Andreas Dannenberg
2016-06-05 3:33 ` Lokesh Vutla [this message]
2016-06-06 11:16 ` Tom Rini
2016-06-06 11:16 ` Tom Rini
2016-06-10 0:35 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57539D87.80006@ti.com \
--to=lokeshvutla@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox