public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: lib: Fix fix push/pop-section directives
Date: Mon, 6 Jun 2016 08:52:39 +0200	[thread overview]
Message-ID: <57551DB7.30403@denx.de> (raw)
In-Reply-To: <1465080415-8794-1-git-send-email-marex@denx.de>

Hello Marek,

Am 05.06.2016 um 00:46 schrieb Marek Vasut:
> Repair typos in the previous "arm: lib: fix push/pop-section directives"
> patch, which prevented VCMA9 board from building.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Fixes: b2f1858455e9 ("arm: lib: fix push/pop-section directives")
> Cc: Tom Warren <twarren@nvidia.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Stephen Warren <swarren@nvidia.com>
> ---
>   arch/arm/lib/lib1funcs.S | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Thanks! Fixes compile problems on on the axm, taurus boards.
Tested current mainline on them with this fix:

Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/arch/arm/lib/lib1funcs.S b/arch/arm/lib/lib1funcs.S
> index 9bf93ce..76968ce 100644
> --- a/arch/arm/lib/lib1funcs.S
> +++ b/arch/arm/lib/lib1funcs.S
> @@ -367,9 +367,9 @@ UNWIND(.fnend)
>   ENDPROC(Ldiv0)
>   .popsection
>
> -.pushsection .text.__gnu_thumb1_case_sqi, "ax"
>   /* Thumb-1 specialities */
>   #if defined(CONFIG_SYS_THUMB_BUILD) && !defined(CONFIG_HAS_THUMB2)
> +.pushsection .text.__gnu_thumb1_case_sqi, "ax"
>   ENTRY(__gnu_thumb1_case_sqi)
>   	push	{r1}
>   	mov	r1, lr
> @@ -383,7 +383,7 @@ ENTRY(__gnu_thumb1_case_sqi)
>   ENDPROC(__gnu_thumb1_case_sqi)
>   .popsection
>
> -_.pushsection .text.__gnu_thumb1_case_uqi, "ax"
> +.pushsection .text.__gnu_thumb1_case_uqi, "ax"
>   ENTRY(__gnu_thumb1_case_uqi)
>   	push	{r1}
>   	mov	r1, lr
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2016-06-06  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-04 22:46 [U-Boot] [PATCH] arm: lib: Fix fix push/pop-section directives Marek Vasut
2016-06-06  6:52 ` Heiko Schocher [this message]
2016-06-16 17:14 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57551DB7.30403@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox