From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 06 Jun 2016 14:25:08 +0200 Subject: [U-Boot] [PATCH v2 4/5] armv8/ls2080: Remove workaround for erratum A008751 In-Reply-To: References: <1464850458-2850-1-git-send-email-sriram.dash@nxp.com> <1464850458-2850-5-git-send-email-sriram.dash@nxp.com> <57502D3D.2040604@denx.de> Message-ID: <57556BA4.4060601@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 06/06/2016 06:23 AM, Sriram Dash wrote: >> -----Original Message----- >> From: Marek Vasut [mailto:marex at denx.de] >> Sent: Thursday, June 02, 2016 6:28 PM >> To: Sriram Dash ; u-boot at lists.denx.de >> Cc: york sun ; albert.u.boot at aribaud.net; Rajesh Bhagat >> >> Subject: Re: [PATCH v2 4/5] armv8/ls2080: Remove workaround for erratum >> A008751 >> >> On 06/02/2016 08:54 AM, Sriram Dash wrote: >>> Remove the errata workaround from soc specific file for LS2080 >> >> The commit message does not explain why this change is legal or needed. >> > > This errata a008751 is applied on Soc specific file currently. > We are moving this errata to a a file where all the errata implementation will take Place for usb for fsl. Implementation of the errata will follow in Patch 5/5. > > However, I cannot reference to the driver specific implementation till it is committed. > So, this is just the description of removing the errata from soc specific file. This explanation should be in the commit message. >>> Signed-off-by: Sriram Dash >>> Signed-off-by: Rajesh Bhagat >>> --- >>> Changes in v2: >>> - No update >>> >>> >>> arch/arm/cpu/armv8/fsl-layerscape/soc.c | 10 ---------- >>> 1 file changed, 10 deletions(-) >>> >>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c >>> b/arch/arm/cpu/armv8/fsl-layerscape/soc.c >>> index 0fb5c7f..5636531 100644 >>> --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c >>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c >>> @@ -122,15 +122,6 @@ void erratum_a009635(void) } >>> #endif /* CONFIG_SYS_FSL_ERRATUM_A009635 */ >>> >>> -static void erratum_a008751(void) >>> -{ >>> -#ifdef CONFIG_SYS_FSL_ERRATUM_A008751 >>> - u32 __iomem *scfg = (u32 __iomem *)SCFG_BASE; >>> - >>> - writel(0x27672b2a, scfg + SCFG_USB3PRM1CR / 4); >>> -#endif >>> -} >>> - >>> static void erratum_rcw_src(void) >>> { >>> #if defined(CONFIG_SPL) >>> @@ -187,7 +178,6 @@ void bypass_smmu(void) } void >>> fsl_lsch3_early_init_f(void) { >>> - erratum_a008751(); >>> erratum_rcw_src(); >>> init_early_memctl_regs(); /* tighten IFC timing */ >>> erratum_a009203(); >>> >> >> >> -- >> Best regards, >> Marek Vasut -- Best regards, Marek Vasut