From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/8] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3
Date: Tue, 7 Jun 2016 10:57:46 +0200 [thread overview]
Message-ID: <57568C8A.7080304@denx.de> (raw)
In-Reply-To: <57568554.9000703@collabora.co.uk>
On 07/06/2016 10:27, Andrew Shadura wrote:
> On 31/05/16 17:55, Andrew Shadura wrote:
>> On 31/05/16 17:35, Stefano Babic wrote:
>>>> But this generates a warning:
>>>>
>>>> w+board/ge/bx50v3/bx50v3.c:324:12: warning: 'detect_baseboard' defined
>>>> but not used [-Wunused-function]
>>>>
>>>> Why do you export it if you do not need it ? It is used only in the hdmi
>>>> detection, that means just if IPU is set.
>> Strange, it wouldn't compile here unless I did this. Apparently it *was*
>> used from somewhere else, but maybe it's no longer. Let me double check.
>
> It seems it was a mistake and this patch may indeed not be needed.
>
> Stefano, are there any comments on other patches?
>
Other patches are fine. Then we agree to apply patches 2-8, and I drop 1/8.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2016-06-07 8:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 11:37 [U-Boot] [PATCH v2 1/8] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3 Andrew Shadura
2016-05-30 11:37 ` [U-Boot] [PATCH v2 2/8] board: ge: bx50v3: don't configure the backlight when there's no display Andrew Shadura
2016-05-30 12:03 ` Martin Donnelly
2016-05-30 11:37 ` [U-Boot] [PATCH v2 3/8] board: ge: bx50v3: make CONFIG_VIDEO optional and disabled by default Andrew Shadura
2016-05-30 12:04 ` Martin Donnelly
2016-05-30 11:37 ` [U-Boot] [PATCH v2 4/8] board: ge: bx50v3: make USB support " Andrew Shadura
2016-05-30 12:10 ` Martin Donnelly
2016-05-30 11:37 ` [U-Boot] [PATCH v2 5/8] board: ge: bx50v3: make network " Andrew Shadura
2016-05-30 12:11 ` Martin Donnelly
2016-05-30 11:37 ` [U-Boot] [PATCH v2 6/8] board: ge: bx50v3: make SATA " Andrew Shadura
2016-05-30 12:12 ` Martin Donnelly
2016-05-30 11:37 ` [U-Boot] [PATCH v2 7/8] board: ge: bx50v3: disable unused features to improve size Andrew Shadura
2016-05-30 12:13 ` Martin Donnelly
2016-05-30 11:37 ` [U-Boot] [PATCH v2 8/8] board: ge: bx50v3: add missing partnum variable Andrew Shadura
2016-05-30 12:28 ` Martin Donnelly
2016-05-30 11:59 ` [U-Boot] [PATCH v2 1/8] board: ge: bx50v3: move detect_baseboard() out of CONFIG_VIDEO_IPUV3 Martin Donnelly
2016-05-31 15:35 ` Stefano Babic
2016-05-31 15:55 ` Andrew Shadura
2016-06-07 8:27 ` Andrew Shadura
2016-06-07 8:57 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57568C8A.7080304@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox