public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: mxs: Remove misleading comments
@ 2016-06-06 12:26 Michael Heimpold
  2016-06-07  1:56 ` Peng Fan
  2016-06-07 16:24 ` Stefano Babic
  0 siblings, 2 replies; 3+ messages in thread
From: Michael Heimpold @ 2016-06-06 12:26 UTC (permalink / raw)
  To: u-boot

Both comments look like being copy & paste errors.

Signed-off-by: Michael Heimpold <michael.heimpold@i2se.com>
Cc: Peng Fan <Peng.Fan@freescale.com>
Cc: Stefano Babic <sbabic@denx.de>
---
 arch/arm/cpu/arm926ejs/mxs/mxs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c b/arch/arm/cpu/arm926ejs/mxs/mxs.c
index a6af0fc..2298620 100644
--- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
+++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
@@ -167,9 +167,9 @@ const char *get_imx_type(u32 imxtype)
 {
 	switch (imxtype) {
 	case MXC_CPU_MX23:
-		return "23";	/* Quad-Plus version of the mx6 */
+		return "23";
 	case MXC_CPU_MX28:
-		return "28";	/* Dual-Plus version of the mx6 */
+		return "28";
 	default:
 		return "??";
 	}
-- 
2.6.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] arm: mxs: Remove misleading comments
  2016-06-06 12:26 [U-Boot] [PATCH] arm: mxs: Remove misleading comments Michael Heimpold
@ 2016-06-07  1:56 ` Peng Fan
  2016-06-07 16:24 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2016-06-07  1:56 UTC (permalink / raw)
  To: u-boot

Hi Michael

> -----Original Message-----
> From: Michael Heimpold [mailto:michael.heimpold at i2se.com]
> Sent: Monday, June 06, 2016 8:27 PM
> To: u-boot at lists.denx.de
> Cc: Michael Heimpold <michael.heimpold@i2se.com>; Peng Fan
> <Peng.Fan@freescale.com>; Stefano Babic <sbabic@denx.de>
> Subject: [PATCH] arm: mxs: Remove misleading comments
> 
> Both comments look like being copy & paste errors.
> 
> Signed-off-by: Michael Heimpold <michael.heimpold@i2se.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Regards,
Peng.

> ---
>  arch/arm/cpu/arm926ejs/mxs/mxs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> index a6af0fc..2298620 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> @@ -167,9 +167,9 @@ const char *get_imx_type(u32 imxtype)  {
>  	switch (imxtype) {
>  	case MXC_CPU_MX23:
> -		return "23";	/* Quad-Plus version of the mx6 */
> +		return "23";
>  	case MXC_CPU_MX28:
> -		return "28";	/* Dual-Plus version of the mx6 */
> +		return "28";
>  	default:
>  		return "??";
>  	}
> --
> 2.6.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] arm: mxs: Remove misleading comments
  2016-06-06 12:26 [U-Boot] [PATCH] arm: mxs: Remove misleading comments Michael Heimpold
  2016-06-07  1:56 ` Peng Fan
@ 2016-06-07 16:24 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2016-06-07 16:24 UTC (permalink / raw)
  To: u-boot

On 06/06/2016 14:26, Michael Heimpold wrote:
> Both comments look like being copy & paste errors.
> 
> Signed-off-by: Michael Heimpold <michael.heimpold@i2se.com>
> Cc: Peng Fan <Peng.Fan@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>  arch/arm/cpu/arm926ejs/mxs/mxs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> index a6af0fc..2298620 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
> @@ -167,9 +167,9 @@ const char *get_imx_type(u32 imxtype)
>  {
>  	switch (imxtype) {
>  	case MXC_CPU_MX23:
> -		return "23";	/* Quad-Plus version of the mx6 */
> +		return "23";
>  	case MXC_CPU_MX28:
> -		return "28";	/* Dual-Plus version of the mx6 */
> +		return "28";
>  	default:
>  		return "??";
>  	}
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-07 16:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-06 12:26 [U-Boot] [PATCH] arm: mxs: Remove misleading comments Michael Heimpold
2016-06-07  1:56 ` Peng Fan
2016-06-07 16:24 ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox