From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <york.sun@nxp.com>
Date: Tue, 7 Jun 2016 17:56:06 -0700
Subject: [U-Boot] [PATCHV5 4/6] ARMv8/Layerscape: switch SMP method
	accordingly
In-Reply-To: <1465108175-35114-4-git-send-email-Zhiqiang.Hou@nxp.com>
References: <1465108175-35114-1-git-send-email-Zhiqiang.Hou@nxp.com>
 <1465108175-35114-4-git-send-email-Zhiqiang.Hou@nxp.com>
Message-ID: <57576D26.9080807@nxp.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 06/04/2016 11:40 PM, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> 
> If the PSCI and PPA is ready, skip the fixup for spin-table and
> waking secondary cores. If not, change SMP method to spin-table,
> and the device node of PSCI will be removed.
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> V5:
>  - Changed the checking if the PSCI feature is ready to read the psci version.
> 
> V4:
>  - Reordered this patch.
> 
>  arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 17 +++++++++++++---
>  arch/arm/cpu/armv8/fsl-layerscape/fdt.c | 36 +++++++++++++++++++++++++++++++++
>  2 files changed, 50 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
> index 672a453..eb566cd 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
> @@ -23,6 +23,9 @@
>  #ifdef CONFIG_FSL_ESDHC
>  #include <fsl_esdhc.h>
>  #endif
> +#ifdef CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT
> +#include <asm/armv8/sec_firmware.h>
> +#endif
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> @@ -618,6 +621,7 @@ int arch_early_init_r(void)
>  {
>  #ifdef CONFIG_MP
>  	int rv = 1;
> +	bool psci_support = false;
>  #endif
>  
>  #ifdef CONFIG_SYS_FSL_ERRATUM_A009635
> @@ -625,9 +629,16 @@ int arch_early_init_r(void)
>  #endif
>  
>  #ifdef CONFIG_MP
> -	rv = fsl_layerscape_wake_seconday_cores();
> -	if (rv)
> -		printf("Did not wake secondary cores\n");
> +#if defined(CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT) && defined(CONFIG_ARMV8_PSCI)
> +	/* Check the psci version to determine if the psci is supported */
> +	psci_support = (int)sec_firmware_support_psci_version() > 0 ?
> +			true : false;

Another comment, even if the function can be used to indicate if psci is
available, do you have to cast it to (int)? I think this can be simplified as
	psci_support = sec_firmware_support_psci_version() > 0;

York