* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
@ 2016-05-25 0:15 Marek Vasut
2016-05-25 3:29 ` Simon Glass
0 siblings, 1 reply; 9+ messages in thread
From: Marek Vasut @ 2016-05-25 0:15 UTC (permalink / raw)
To: u-boot
Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
drop them from the rockchip-specific Kconfig file.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
---
arch/arm/mach-rockchip/Kconfig | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index d3bddb7..5f6046a 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
and video codec support. Peripherals include Gigabit Ethernet,
USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
-config SYS_MALLOC_F
- default y
-
-config SPL_SYS_MALLOC_SIMPLE
- default y
-
config SPL_DM
default y
--
2.7.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
2016-05-25 0:15 [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE Marek Vasut
@ 2016-05-25 3:29 ` Simon Glass
2016-05-25 12:26 ` Marek Vasut
0 siblings, 1 reply; 9+ messages in thread
From: Simon Glass @ 2016-05-25 3:29 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
> drop them from the rockchip-specific Kconfig file.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
> arch/arm/mach-rockchip/Kconfig | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index d3bddb7..5f6046a 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
> and video codec support. Peripherals include Gigabit Ethernet,
> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>
> -config SYS_MALLOC_F
> - default y
> -
> -config SPL_SYS_MALLOC_SIMPLE
> - default y
> -
> config SPL_DM
> default y
>
> --
> 2.7.0
>
Will these still be enabled some other way?
Regards,
Simon
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
2016-05-25 3:29 ` Simon Glass
@ 2016-05-25 12:26 ` Marek Vasut
2016-06-08 2:43 ` Simon Glass
0 siblings, 1 reply; 9+ messages in thread
From: Marek Vasut @ 2016-05-25 12:26 UTC (permalink / raw)
To: u-boot
On 05/25/2016 05:29 AM, Simon Glass wrote:
> Hi Marek,
>
> On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
>> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
>> drop them from the rockchip-specific Kconfig file.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> ---
>> arch/arm/mach-rockchip/Kconfig | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>> index d3bddb7..5f6046a 100644
>> --- a/arch/arm/mach-rockchip/Kconfig
>> +++ b/arch/arm/mach-rockchip/Kconfig
>> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
>> and video codec support. Peripherals include Gigabit Ethernet,
>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>>
>> -config SYS_MALLOC_F
>> - default y
>> -
>> -config SPL_SYS_MALLOC_SIMPLE
>> - default y
>> -
>> config SPL_DM
>> default y
>>
>> --
>> 2.7.0
>>
>
> Will these still be enabled some other way?
That's why it's RFC, I believe the rockchip platforms would need to add
those to their defconfig, right ?
> Regards,
> Simon
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
2016-05-25 12:26 ` Marek Vasut
@ 2016-06-08 2:43 ` Simon Glass
2016-06-08 3:02 ` Marek Vasut
0 siblings, 1 reply; 9+ messages in thread
From: Simon Glass @ 2016-06-08 2:43 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 25 May 2016 at 05:26, Marek Vasut <marex@denx.de> wrote:
> On 05/25/2016 05:29 AM, Simon Glass wrote:
>> Hi Marek,
>>
>> On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
>>> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
>>> drop them from the rockchip-specific Kconfig file.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> Cc: Tom Rini <trini@konsulko.com>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> ---
>>> arch/arm/mach-rockchip/Kconfig | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>> index d3bddb7..5f6046a 100644
>>> --- a/arch/arm/mach-rockchip/Kconfig
>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
>>> and video codec support. Peripherals include Gigabit Ethernet,
>>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>>>
>>> -config SYS_MALLOC_F
>>> - default y
>>> -
>>> -config SPL_SYS_MALLOC_SIMPLE
>>> - default y
>>> -
>>> config SPL_DM
>>> default y
>>>
>>> --
>>> 2.7.0
>>>
>>
>> Will these still be enabled some other way?
>
> That's why it's RFC, I believe the rockchip platforms would need to add
> those to their defconfig, right ?
Well, Rockchip boards cannot work without these, which is why they default to y.
Regards,
Simon
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
2016-06-08 2:43 ` Simon Glass
@ 2016-06-08 3:02 ` Marek Vasut
2016-06-08 4:44 ` Simon Glass
0 siblings, 1 reply; 9+ messages in thread
From: Marek Vasut @ 2016-06-08 3:02 UTC (permalink / raw)
To: u-boot
On 06/08/2016 04:43 AM, Simon Glass wrote:
> Hi Marek,
Hi!
> On 25 May 2016 at 05:26, Marek Vasut <marex@denx.de> wrote:
>> On 05/25/2016 05:29 AM, Simon Glass wrote:
>>> Hi Marek,
>>>
>>> On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
>>>> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
>>>> drop them from the rockchip-specific Kconfig file.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> Cc: Tom Rini <trini@konsulko.com>
>>>> Cc: Simon Glass <sjg@chromium.org>
>>>> ---
>>>> arch/arm/mach-rockchip/Kconfig | 6 ------
>>>> 1 file changed, 6 deletions(-)
>>>>
>>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>>> index d3bddb7..5f6046a 100644
>>>> --- a/arch/arm/mach-rockchip/Kconfig
>>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>>> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
>>>> and video codec support. Peripherals include Gigabit Ethernet,
>>>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>>>>
>>>> -config SYS_MALLOC_F
>>>> - default y
>>>> -
>>>> -config SPL_SYS_MALLOC_SIMPLE
>>>> - default y
>>>> -
>>>> config SPL_DM
>>>> default y
>>>>
>>>> --
>>>> 2.7.0
>>>>
>>>
>>> Will these still be enabled some other way?
>>
>> That's why it's RFC, I believe the rockchip platforms would need to add
>> those to their defconfig, right ?
>
> Well, Rockchip boards cannot work without these, which is why they default to y.
I understand that, but these Kconfig options are generic, so they
shouldn't be defined in the mach-rockchip/Kconfig file, but in some
generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in
some defconfig , right ?
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
2016-06-08 3:02 ` Marek Vasut
@ 2016-06-08 4:44 ` Simon Glass
2016-06-08 13:18 ` Marek Vasut
0 siblings, 1 reply; 9+ messages in thread
From: Simon Glass @ 2016-06-08 4:44 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 7 June 2016 at 20:02, Marek Vasut <marex@denx.de> wrote:
> On 06/08/2016 04:43 AM, Simon Glass wrote:
>> Hi Marek,
>
> Hi!
>
>> On 25 May 2016 at 05:26, Marek Vasut <marex@denx.de> wrote:
>>> On 05/25/2016 05:29 AM, Simon Glass wrote:
>>>> Hi Marek,
>>>>
>>>> On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
>>>>> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
>>>>> drop them from the rockchip-specific Kconfig file.
>>>>>
>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>> Cc: Tom Rini <trini@konsulko.com>
>>>>> Cc: Simon Glass <sjg@chromium.org>
>>>>> ---
>>>>> arch/arm/mach-rockchip/Kconfig | 6 ------
>>>>> 1 file changed, 6 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>>>> index d3bddb7..5f6046a 100644
>>>>> --- a/arch/arm/mach-rockchip/Kconfig
>>>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>>>> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
>>>>> and video codec support. Peripherals include Gigabit Ethernet,
>>>>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>>>>>
>>>>> -config SYS_MALLOC_F
>>>>> - default y
>>>>> -
>>>>> -config SPL_SYS_MALLOC_SIMPLE
>>>>> - default y
>>>>> -
>>>>> config SPL_DM
>>>>> default y
>>>>>
>>>>> --
>>>>> 2.7.0
>>>>>
>>>>
>>>> Will these still be enabled some other way?
>>>
>>> That's why it's RFC, I believe the rockchip platforms would need to add
>>> those to their defconfig, right ?
>>
>> Well, Rockchip boards cannot work without these, which is why they default to y.
>
> I understand that, but these Kconfig options are generic, so they
> shouldn't be defined in the mach-rockchip/Kconfig file, but in some
> generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in
> some defconfig , right ?
They are not being defined, just their default value is being set.
Regards,
Simon
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
2016-06-08 4:44 ` Simon Glass
@ 2016-06-08 13:18 ` Marek Vasut
2016-06-10 0:34 ` Simon Glass
0 siblings, 1 reply; 9+ messages in thread
From: Marek Vasut @ 2016-06-08 13:18 UTC (permalink / raw)
To: u-boot
On 06/08/2016 06:44 AM, Simon Glass wrote:
> Hi Marek,
>
> On 7 June 2016 at 20:02, Marek Vasut <marex@denx.de> wrote:
>> On 06/08/2016 04:43 AM, Simon Glass wrote:
>>> Hi Marek,
>>
>> Hi!
>>
>>> On 25 May 2016 at 05:26, Marek Vasut <marex@denx.de> wrote:
>>>> On 05/25/2016 05:29 AM, Simon Glass wrote:
>>>>> Hi Marek,
>>>>>
>>>>> On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
>>>>>> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
>>>>>> drop them from the rockchip-specific Kconfig file.
>>>>>>
>>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>>> Cc: Tom Rini <trini@konsulko.com>
>>>>>> Cc: Simon Glass <sjg@chromium.org>
>>>>>> ---
>>>>>> arch/arm/mach-rockchip/Kconfig | 6 ------
>>>>>> 1 file changed, 6 deletions(-)
>>>>>>
>>>>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>>>>> index d3bddb7..5f6046a 100644
>>>>>> --- a/arch/arm/mach-rockchip/Kconfig
>>>>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>>>>> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
>>>>>> and video codec support. Peripherals include Gigabit Ethernet,
>>>>>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>>>>>>
>>>>>> -config SYS_MALLOC_F
>>>>>> - default y
>>>>>> -
>>>>>> -config SPL_SYS_MALLOC_SIMPLE
>>>>>> - default y
>>>>>> -
>>>>>> config SPL_DM
>>>>>> default y
>>>>>>
>>>>>> --
>>>>>> 2.7.0
>>>>>>
>>>>>
>>>>> Will these still be enabled some other way?
>>>>
>>>> That's why it's RFC, I believe the rockchip platforms would need to add
>>>> those to their defconfig, right ?
>>>
>>> Well, Rockchip boards cannot work without these, which is why they default to y.
>>
>> I understand that, but these Kconfig options are generic, so they
>> shouldn't be defined in the mach-rockchip/Kconfig file, but in some
>> generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in
>> some defconfig , right ?
>
> They are not being defined, just their default value is being set.
Checking with git grep, they are defined in the top-level Kconfig.
I recall when I tried using those on mips, it complained about the
entries in mach-rockchip though. So why are the defaults selected
this way instead of using "select" in ARCH_ROCKCHIP symbol ? Isn't
that how it's usually done ?
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
2016-06-08 13:18 ` Marek Vasut
@ 2016-06-10 0:34 ` Simon Glass
2016-06-10 0:59 ` Marek Vasut
0 siblings, 1 reply; 9+ messages in thread
From: Simon Glass @ 2016-06-10 0:34 UTC (permalink / raw)
To: u-boot
Hi Marek,
On 8 June 2016 at 07:18, Marek Vasut <marex@denx.de> wrote:
> On 06/08/2016 06:44 AM, Simon Glass wrote:
>> Hi Marek,
>>
>> On 7 June 2016 at 20:02, Marek Vasut <marex@denx.de> wrote:
>>> On 06/08/2016 04:43 AM, Simon Glass wrote:
>>>> Hi Marek,
>>>
>>> Hi!
>>>
>>>> On 25 May 2016 at 05:26, Marek Vasut <marex@denx.de> wrote:
>>>>> On 05/25/2016 05:29 AM, Simon Glass wrote:
>>>>>> Hi Marek,
>>>>>>
>>>>>> On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
>>>>>>> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
>>>>>>> drop them from the rockchip-specific Kconfig file.
>>>>>>>
>>>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>>>> Cc: Tom Rini <trini@konsulko.com>
>>>>>>> Cc: Simon Glass <sjg@chromium.org>
>>>>>>> ---
>>>>>>> arch/arm/mach-rockchip/Kconfig | 6 ------
>>>>>>> 1 file changed, 6 deletions(-)
>>>>>>>
>>>>>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>>>>>> index d3bddb7..5f6046a 100644
>>>>>>> --- a/arch/arm/mach-rockchip/Kconfig
>>>>>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>>>>>> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
>>>>>>> and video codec support. Peripherals include Gigabit Ethernet,
>>>>>>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>>>>>>>
>>>>>>> -config SYS_MALLOC_F
>>>>>>> - default y
>>>>>>> -
>>>>>>> -config SPL_SYS_MALLOC_SIMPLE
>>>>>>> - default y
>>>>>>> -
>>>>>>> config SPL_DM
>>>>>>> default y
>>>>>>>
>>>>>>> --
>>>>>>> 2.7.0
>>>>>>>
>>>>>>
>>>>>> Will these still be enabled some other way?
>>>>>
>>>>> That's why it's RFC, I believe the rockchip platforms would need to add
>>>>> those to their defconfig, right ?
>>>>
>>>> Well, Rockchip boards cannot work without these, which is why they default to y.
>>>
>>> I understand that, but these Kconfig options are generic, so they
>>> shouldn't be defined in the mach-rockchip/Kconfig file, but in some
>>> generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in
>>> some defconfig , right ?
>>
>> They are not being defined, just their default value is being set.
>
> Checking with git grep, they are defined in the top-level Kconfig.
> I recall when I tried using those on mips, it complained about the
> entries in mach-rockchip though. So why are the defaults selected
> this way instead of using "select" in ARCH_ROCKCHIP symbol ? Isn't
> that how it's usually done ?
That's odd, because these are inside an 'if ARCH_ROCKCHIP' clause. But
I'm fine with moving to 'select' for these if that is better. It is
unlikely anyone would want to disable these. But as it stands, your
patch breaks things :-)
Regards,
Simon
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE
2016-06-10 0:34 ` Simon Glass
@ 2016-06-10 0:59 ` Marek Vasut
0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2016-06-10 0:59 UTC (permalink / raw)
To: u-boot
On 06/10/2016 02:34 AM, Simon Glass wrote:
> Hi Marek,
Hi!
> On 8 June 2016 at 07:18, Marek Vasut <marex@denx.de> wrote:
>> On 06/08/2016 06:44 AM, Simon Glass wrote:
>>> Hi Marek,
>>>
>>> On 7 June 2016 at 20:02, Marek Vasut <marex@denx.de> wrote:
>>>> On 06/08/2016 04:43 AM, Simon Glass wrote:
>>>>> Hi Marek,
>>>>
>>>> Hi!
>>>>
>>>>> On 25 May 2016 at 05:26, Marek Vasut <marex@denx.de> wrote:
>>>>>> On 05/25/2016 05:29 AM, Simon Glass wrote:
>>>>>>> Hi Marek,
>>>>>>>
>>>>>>> On 24 May 2016 at 18:15, Marek Vasut <marex@denx.de> wrote:
>>>>>>>> Both SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE are generic config options,
>>>>>>>> drop them from the rockchip-specific Kconfig file.
>>>>>>>>
>>>>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>>>>> Cc: Tom Rini <trini@konsulko.com>
>>>>>>>> Cc: Simon Glass <sjg@chromium.org>
>>>>>>>> ---
>>>>>>>> arch/arm/mach-rockchip/Kconfig | 6 ------
>>>>>>>> 1 file changed, 6 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>>>>>>> index d3bddb7..5f6046a 100644
>>>>>>>> --- a/arch/arm/mach-rockchip/Kconfig
>>>>>>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>>>>>>> @@ -17,12 +17,6 @@ config ROCKCHIP_RK3036
>>>>>>>> and video codec support. Peripherals include Gigabit Ethernet,
>>>>>>>> USB2 host and OTG, SDIO, I2S, UART, SPI, I2C and PWMs.
>>>>>>>>
>>>>>>>> -config SYS_MALLOC_F
>>>>>>>> - default y
>>>>>>>> -
>>>>>>>> -config SPL_SYS_MALLOC_SIMPLE
>>>>>>>> - default y
>>>>>>>> -
>>>>>>>> config SPL_DM
>>>>>>>> default y
>>>>>>>>
>>>>>>>> --
>>>>>>>> 2.7.0
>>>>>>>>
>>>>>>>
>>>>>>> Will these still be enabled some other way?
>>>>>>
>>>>>> That's why it's RFC, I believe the rockchip platforms would need to add
>>>>>> those to their defconfig, right ?
>>>>>
>>>>> Well, Rockchip boards cannot work without these, which is why they default to y.
>>>>
>>>> I understand that, but these Kconfig options are generic, so they
>>>> shouldn't be defined in the mach-rockchip/Kconfig file, but in some
>>>> generic Kconfig file and then selected by ARCH_ROCKCHIP symbol or in
>>>> some defconfig , right ?
>>>
>>> They are not being defined, just their default value is being set.
>>
>> Checking with git grep, they are defined in the top-level Kconfig.
>> I recall when I tried using those on mips, it complained about the
>> entries in mach-rockchip though. So why are the defaults selected
>> this way instead of using "select" in ARCH_ROCKCHIP symbol ? Isn't
>> that how it's usually done ?
>
> That's odd, because these are inside an 'if ARCH_ROCKCHIP' clause. But
> I'm fine with moving to 'select' for these if that is better. It is
> unlikely anyone would want to disable these. But as it stands, your
> patch breaks things :-)
OK, I am not really sure about this patch and I have no real use for it,
so let's drop it for now.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-06-10 0:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-25 0:15 [U-Boot] [RFC][PATCH] arm: rk: Drop SYS_MALLOC_F and SPL_SYS_MALLOC_SIMPLE Marek Vasut
2016-05-25 3:29 ` Simon Glass
2016-05-25 12:26 ` Marek Vasut
2016-06-08 2:43 ` Simon Glass
2016-06-08 3:02 ` Marek Vasut
2016-06-08 4:44 ` Simon Glass
2016-06-08 13:18 ` Marek Vasut
2016-06-10 0:34 ` Simon Glass
2016-06-10 0:59 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox