From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 09/12] mmc: omap_hsmmc: enable 8bit interface for eMMC for AM33xx
Date: Wed, 8 Jun 2016 11:53:39 +0300 [thread overview]
Message-ID: <5757DD13.3030907@compulab.co.il> (raw)
In-Reply-To: <1465281085-10481-10-git-send-email-hs@denx.de>
Hi Heiko,
On 06/07/2016 09:31 AM, Heiko Schocher wrote:
> Enable 8bit interface on HSMMC2 for am33xx to support 8bit eMMC chips.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> ---
>
> Changes in v3: None
> Changes in v2:
> - add Reviewed-by from Tom Rini
>
> drivers/mmc/omap_hsmmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c
> index be34057..d007b56 100644
> --- a/drivers/mmc/omap_hsmmc.c
> +++ b/drivers/mmc/omap_hsmmc.c
> @@ -701,6 +701,7 @@ int omap_mmc_init(int dev_index, uint host_caps_mask, uint f_max, int cd_gpio,
> priv_data->base_addr = (struct hsmmc *)OMAP_HSMMC2_BASE;
> #if (defined(CONFIG_OMAP44XX) || defined(CONFIG_OMAP54XX) || \
> defined(CONFIG_DRA7XX) || defined(CONFIG_AM57XX) || \
> + defined(CONFIG_AM33XX) || \
> defined(CONFIG_AM43XX) || defined(CONFIG_SOC_KEYSTONE)) && \
> defined(CONFIG_HSMMC2_8BIT)
Don't you find the above habit terrible - adding more and more SoCs
to the ifdef...
Don't get me wrong, I'm not trying to prevent this patch - please merge it.
But I think, we should do something about the above (and I can see also other
cases in the same function).
> /* Enable 8-bit interface for eMMC on OMAP4/5 or DRA7XX */
>
--
Regards,
Igor.
next prev parent reply other threads:[~2016-06-08 8:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 6:31 [U-Boot] [PATCH v3 00/12] am335x: add support for the am335x based bosch shc board Heiko Schocher
2016-06-07 6:31 ` [U-Boot] [PATCH v3 01/12] common: bootdelay: move CONFIG_BOOTDELAY into a Kconfig option Heiko Schocher
2016-06-08 2:54 ` Viresh Kumar
2016-06-08 8:52 ` Igor Grinberg
2016-06-09 18:02 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 02/12] tests: py: disable main_signon check for printenv cmd Heiko Schocher
2016-06-09 18:02 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 03/12] power, tps65217: add some defines Heiko Schocher
2016-06-09 18:02 ` [U-Boot] [U-Boot,v3,03/12] " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 04/12] arm, am335x: add some missing GPIO register definitions Heiko Schocher
2016-06-09 18:02 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 05/12] am335x: add some missing CM_CLKMODE_DPLL_SSC macros Heiko Schocher
2016-06-09 18:02 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 06/12] arm, am335x: Enable Spread Spectrum for the MPU Heiko Schocher
2016-06-09 18:03 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 07/12] bootstage: call show_boot_progress also in SPL Heiko Schocher
2016-06-09 18:03 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 08/12] mmc: revert mmc: Handle switch error status bit in MMC card status Heiko Schocher
2016-06-09 18:03 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 09/12] mmc: omap_hsmmc: enable 8bit interface for eMMC for AM33xx Heiko Schocher
2016-06-08 8:53 ` Igor Grinberg [this message]
2016-06-09 18:03 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 10/12] armv7: omap-common: make SPL board_mmc_init() weak Heiko Schocher
2016-06-09 18:03 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 11/12] doc, spl, am335x: update am335x-network Heiko Schocher
2016-06-09 18:03 ` [U-Boot] [U-Boot, v3, " Tom Rini
2016-06-07 6:31 ` [U-Boot] [PATCH v3 12/12] am335x, shc: add support for the am335x based bosch shc board Heiko Schocher
2016-06-09 18:03 ` [U-Boot] [U-Boot, v3, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5757DD13.3030907@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox