From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Date: Wed, 8 Jun 2016 11:53:39 +0300 Subject: [U-Boot] [PATCH v3 09/12] mmc: omap_hsmmc: enable 8bit interface for eMMC for AM33xx In-Reply-To: <1465281085-10481-10-git-send-email-hs@denx.de> References: <1465281085-10481-1-git-send-email-hs@denx.de> <1465281085-10481-10-git-send-email-hs@denx.de> Message-ID: <5757DD13.3030907@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, On 06/07/2016 09:31 AM, Heiko Schocher wrote: > Enable 8bit interface on HSMMC2 for am33xx to support 8bit eMMC chips. > > Signed-off-by: Heiko Schocher > Reviewed-by: Tom Rini > > --- > > Changes in v3: None > Changes in v2: > - add Reviewed-by from Tom Rini > > drivers/mmc/omap_hsmmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > index be34057..d007b56 100644 > --- a/drivers/mmc/omap_hsmmc.c > +++ b/drivers/mmc/omap_hsmmc.c > @@ -701,6 +701,7 @@ int omap_mmc_init(int dev_index, uint host_caps_mask, uint f_max, int cd_gpio, > priv_data->base_addr = (struct hsmmc *)OMAP_HSMMC2_BASE; > #if (defined(CONFIG_OMAP44XX) || defined(CONFIG_OMAP54XX) || \ > defined(CONFIG_DRA7XX) || defined(CONFIG_AM57XX) || \ > + defined(CONFIG_AM33XX) || \ > defined(CONFIG_AM43XX) || defined(CONFIG_SOC_KEYSTONE)) && \ > defined(CONFIG_HSMMC2_8BIT) Don't you find the above habit terrible - adding more and more SoCs to the ifdef... Don't get me wrong, I'm not trying to prevent this patch - please merge it. But I think, we should do something about the above (and I can see also other cases in the same function). > /* Enable 8-bit interface for eMMC on OMAP4/5 or DRA7XX */ > -- Regards, Igor.