public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6sabresd: Allow LVDS backlight to be functional after a kernel reboot
Date: Wed, 8 Jun 2016 22:31:15 +0200	[thread overview]
Message-ID: <57588093.9080704@denx.de> (raw)
In-Reply-To: <1465409131-14574-1-git-send-email-marco.franchi@nxp.com>

Hi Marco,

On 08/06/2016 20:05, Marco Franchi wrote:
> Currently the LVDS backlight does not work in U-Boot after a ?reboot? comand
> in the kernel.
> 
> This problem occurs because the kernel uses this pin in PWM mode and U-Boot
> does not configure the backlight pin as GPIO functionality.
> 
> So fix the problem by explicitly configuring the backlight pin as GPIO in
> U-Boot.
> 
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
> ---
>  board/freescale/mx6sabresd/mx6sabresd.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
> index 54ba36b..28c969d 100644
> --- a/board/freescale/mx6sabresd/mx6sabresd.c
> +++ b/board/freescale/mx6sabresd/mx6sabresd.c
> @@ -177,13 +177,27 @@ static iomux_v3_cfg_t const rgb_pads[] = {
>  	MX6_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 | MUX_PAD_CTRL(NO_PAD_CTRL),
>  	MX6_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 | MUX_PAD_CTRL(NO_PAD_CTRL),
>  	MX6_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 | MUX_PAD_CTRL(NO_PAD_CTRL),
> +};
> +
> +static iomux_v3_cfg_t const bl_pads[] = {
>  	MX6_PAD_SD1_DAT3__GPIO1_IO21 | MUX_PAD_CTRL(NO_PAD_CTRL),
>  };
>  
> +static void enable_backlight(void)
> +{
> +	imx_iomux_v3_setup_multiple_pads(bl_pads, ARRAY_SIZE(bl_pads));
> +	gpio_direction_output(DISP0_PWR_EN, 1);
> +}
> +
>  static void enable_rgb(struct display_info_t const *dev)
>  {
>  	imx_iomux_v3_setup_multiple_pads(rgb_pads, ARRAY_SIZE(rgb_pads));
> -	gpio_direction_output(DISP0_PWR_EN, 1);
> +	enable_backlight();
> +}
> +
> +static void enable_lvds(struct display_info_t const *dev)
> +{
> +	enable_backlight();
>  }
>  
>  static struct i2c_pads_info i2c_pad_info1 = {
> @@ -370,7 +384,7 @@ struct display_info_t const displays[] = {{
>  	.addr	= 0,
>  	.pixfmt	= IPU_PIX_FMT_RGB666,
>  	.detect	= NULL,
> -	.enable	= NULL,
> +	.enable	= enable_lvds,
>  	.mode	= {
>  		.name           = "Hannstar-XGA",
>  		.refresh        = 60,
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2016-06-08 20:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 18:05 [U-Boot] [PATCH] mx6sabresd: Allow LVDS backlight to be functional after a kernel reboot Marco Franchi
2016-06-08 20:31 ` Stefano Babic [this message]
2016-06-08 20:47 ` Fabio Estevam
2016-06-18  8:28 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57588093.9080704@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox