From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 9 Jun 2016 08:10:44 +0200 Subject: [U-Boot] [PATCH 7/8] x86: Probe pinctrl driver in cpu_init_r() In-Reply-To: <1465387659-30011-8-git-send-email-bmeng.cn@gmail.com> References: <1465387659-30011-1-git-send-email-bmeng.cn@gmail.com> <1465387659-30011-8-git-send-email-bmeng.cn@gmail.com> Message-ID: <57590864.9020408@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08.06.2016 14:07, Bin Meng wrote: > At present pinctrl driver gets probed in ich6_gpio driver's probe > routine, which has two issues: > > - Pin's PADs only gets configured when GPIO driver is probed, which > is not done by default. This leaves the board in a partially > functional state as we must initialize PADs correctly to get > perepherals fully working. > - The probe routine of pinctrl driver is called multiple times, as > normally there are multiple GPIO controllers. It should really > be called just once. > > Move the call to syscon_get_by_driver_data() from ich6_gpio driver > to cpu_init_r(). > > Signed-off-by: Bin Meng Reviewed-by: Stefan Roese Thanks, Stefan