From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C59FC432BE for ; Thu, 12 Aug 2021 06:51:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 026E560EFE for ; Thu, 12 Aug 2021 06:51:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 026E560EFE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6616182C2C; Thu, 12 Aug 2021 08:51:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628751065; bh=mWd7GfGGzJIV8uA4w1oZRw8Coh5XpDJ/NVtkkleEJts=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AF53OYEMfQepzr0hs/20kxInKqF2+Z491V5EN/2V9z6V6nIuzcvrMqxEBc0ATy9n+ NFGMULMDwelHNnigu2DPnVPFqPvOqlfajcbfUaZWfbgNnidTni46EdMbOS0KxqZqOl 1le1mRbplZQsZEALDBC/S9FDjvs7MxFdx9jFwfxO3eNjRfONxs+GgZd8xnienilnv8 m7U4HRaOvBiVA1a+hRjuKUhxesbMTKQejIJrpc+PrGufq53F1/ScGbIBw7NMU1VzTY lYSHgkzw6XKqNo/fQ/Ha5NvmXhpkBpVR2IZ2SJEeAJAZeUiKgWm+S3z1mFoGdrLGrL ZlZfMYLIwAh8w== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D00B682C2C for ; Thu, 12 Aug 2021 08:51:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628751062; bh=mWd7GfGGzJIV8uA4w1oZRw8Coh5XpDJ/NVtkkleEJts=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=ihgSjQQstRPH8QgdT3SsMHHfNxnweDlDz8fRT9sXG1GQGkITdRbJA4A5E3898z5ts rrU8P9PMdMPIpnQg+Cn0ju0G+K+VYh9bn1B9xP0+Ha6cFS17IBWDR6v0tff8E9fA85 ap5sxGiJned4ZC91uyd8TUNISbttLkFRL27P97H4sPK8aEEfRNyOvBk8ZK1O+wChIB 0/RX4fBT2b/gESA/v5/mJ8g/r49blNN6y+A54KcRnR33sdIRrYa/q0a+rRHWsYwy8x i4e2I1rE6/bRKx6VausGmjwv0VlU/J31JaEWBmgz6KZdgPWw5xq7+8IhYj1wONPMZy qAHV6wuXX6t5w== Received: by janitor.denx.de (Postfix, from userid 108) id 126F6A0260; Thu, 12 Aug 2021 08:51:02 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 17404A005F; Thu, 12 Aug 2021 08:50:52 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 071481E2304; Thu, 12 Aug 2021 08:50:52 +0200 (CEST) To: Rasmus Villemoes cc: u-boot@lists.denx.de, Simon Glass , Stefan Roese , Tom Rini From: Wolfgang Denk Subject: Re: [PATCH v5 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset() MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20210811124800.2593226-10-rasmus.villemoes@prevas.dk> References: <20210811124800.2593226-1-rasmus.villemoes@prevas.dk> <20210811124800.2593226-10-rasmus.villemoes@prevas.dk> Comments: In-reply-to Rasmus Villemoes message dated "Wed, 11 Aug 2021 14:47:57 +0200." Date: Thu, 12 Aug 2021 08:50:52 +0200 Message-ID: <575933.1628751052@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Rasmus, In message <20210811124800.2593226-10-rasmus.villemoes@prevas.dk> you wrote: > > + ret = uclass_get(UCLASS_WDT, &uc); > + if (ret) { > + log_debug("Error getting UCLASS_WDT: %d\n", ret); > + return 0; > + } Here the error goes silent, so we should fix the callers to report it. > + uclass_foreach_dev(dev, uc) { > + ret = device_probe(dev); > + if (ret) { > + log_debug("Error probing %s: %d\n", dev->name, ret); > + continue; > } Here the situation is different. The probing error is never reported anywhere. Is it really a normal condition that a device_probe() fails here? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Here is an Appalachian version of management's answer to those who are concerned with the fate of the project: "Don't worry about the mule. Just load the wagon." - Mike Dennison's hillbilly uncle