[U-Boot] [PATCH] libfdt: Add option to disable arch_fixup_fdt() calls

Michal Simek
2016-07-15T07:36:05Z

On 10.6.2016 18:44, Simon Glass wrote:
> Hi Michal,
>
> On 9 June 2016 at 08:23, Michal Simek <michal.simek@xilinx.com> wrote:
>> Disable arch_fixup_fdt() calls for cases where U-Boot shouldn't update
>> memory setup in DTB file.
>> One example of usage of this option is to boot OS with different memory
>> setup than U-Boot use.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Kconfig | 8 ++++++++
>> arch/arm/lib/bootm-fdt.c | 2 ++
>> common/image-fdt.c | 3 +++
>> 3 files changed, 13 insertions(+)
>>
>> diff --git a/Kconfig b/Kconfig
>> index 4b4621666560..3efba624ecff 100644
>> --- a/Kconfig
>> +++ b/Kconfig
>> @@ -291,6 +291,14 @@ config SYS_CLK_FREQ
>> help
>> TODO: Move CONFIG_SYS_CLK_FREQ for all the architecture
>>
>> +config DISABLE_ARCH_FIXUP_FDT
>> + bool "Disable arch_fixup_fdt() call"
>> + depends on ARM
>> + help
>> + Disable FDT memory map syncup before OS boot. This feature can be
>> + used for booting OS with different memory setup where the part of
>> + the memory location should be used for different purpose.
>> +
>> endmenu # Boot images
>>
>
> I think this would be better as a positive Kconfig - ARCH_FIXUP_FDT.
>
> Also this is pretty ugly - with a weak function that gets #ifdefed
> out. How about changing it so that the function is only called if the
> Kconfig is set, and then it does not have to be weak?

All fixed in v2.

Thanks,
Michal